Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 1233558" data-attributes="member: 82144">I have no strong preference. I would only expect:<ul>
<li data-xf-list-type="ul">...if audio renderer removal matching is 100% reliable, the &quot;stop...&quot; setting should be removed...</li>
<li data-xf-list-type="ul">...or if audio renderer removal matching is not reliable, the &quot;stop...&quot; setting must have higher precedence over the matching</li>
</ul>To be clear, what I mean for the second option is:<ol>
<li data-xf-list-type="ol">If matching detects that the current audio renderer is removed, playback should be stopped regardless of the value of the &quot;stop...&quot; setting.</li>
<li data-xf-list-type="ol">If the &quot;stop...&quot; setting is enabled, playback should be stopped when any audio renderer is removed.</li>
</ol>This second point is the part that is not working right now. That can be &quot;fixed&quot; by changing:if (_stopOnLostAudioRenderer &amp;&amp; GUIGraphicsContext.CurrentAudioRenderer.Trim().ToLowerInvariant() == deviceName.Trim().ToLowerInvariant())...to...if (_stopOnLostAudioRenderer || GUIGraphicsContext.CurrentAudioRenderer.Trim().ToLowerInvariant() == deviceName.Trim().ToLowerInvariant())</blockquote>

[QUOTE="mm1352000, post: 1233558, member: 82144"] I have no strong preference. I would only expect: [LIST] [*]...if audio renderer removal matching is 100% reliable, the "stop..." setting should be removed... [*]...or if audio renderer removal matching is not reliable, the "stop..." setting must have higher precedence over the matching [/LIST] To be clear, what I mean for the second option is: [LIST=1] [*]If matching detects that the [B]current[/B] audio renderer is removed, playback should be stopped [B]regardless of the value of the "stop..." setting[/B]. [*]If the "stop..." setting is enabled, playback should be stopped when [B]any[/B] audio renderer is removed. [/LIST] This second point is the part that is not working right now. That can be "fixed" by changing: if (_stopOnLostAudioRenderer [B]&& [/B]GUIGraphicsContext.CurrentAudioRenderer.Trim().ToLowerInvariant() == deviceName.Trim().ToLowerInvariant()) ...to... if (_stopOnLostAudioRenderer [B]||[/B] GUIGraphicsContext.CurrentAudioRenderer.Trim().ToLowerInvariant() == deviceName.Trim().ToLowerInvariant()) [/QUOTE]

Verification