Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 886643" data-attributes="member: 82144">Hmmm, problem seems to be that the stream with PID 0x30 (with stream type 0x80) is incorrectly detected as video.&nbsp;PmtParser.cpp:[code]&nbsp; &nbsp; &nbsp; if (stream_type==SERVICE_TYPE_DCII_OR_LPCM &amp;&amp; !lpcm_audio_found)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; VideoPid pid;&nbsp; &nbsp; &nbsp; &nbsp; pid.Pid=elementary_PID;&nbsp; &nbsp; &nbsp; &nbsp; pid.VideoServiceType=SERVICE_TYPE_VIDEO_MPEG2;&nbsp; &nbsp; &nbsp; &nbsp; m_pidInfo.videoPids.push_back(pid);&nbsp; &nbsp; &nbsp; }[/code]&nbsp;Obviously this is not a DC II stream, but in that context I don't know if we are able to distinguish properly. Anybody know anything about distinguishing between DC II and DVB MPEG transport streams? <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin&nbsp; &nbsp; :D" loading="lazy" data-shortname=":D" />&nbsp;I can think of two possible &quot;solutions&quot;:1. Only allow one video PID to be recognised at the PMT parsing stage. Since the rest of the TsReader doesn't seem to support multiple video streams, this would likely be appropriate... although there is still the problem of selecting the correct PID.2. TsReader is likely to be encountering DC II streams on a considerably (and increasingly) rarer basis than it would DVB streams... and DC II streams are also unlikely to have 2 video streams. We could prioritise the stream that we *know* is video over the stream that is possibly DC II video by doing the following:&nbsp;[code]&nbsp; &nbsp; &nbsp; if(stream_type==SERVICE_TYPE_VIDEO_MPEG1&nbsp; &nbsp; &nbsp; &nbsp; || stream_type==SERVICE_TYPE_VIDEO_MPEG2&nbsp; &nbsp; &nbsp; &nbsp; || stream_type==SERVICE_TYPE_VIDEO_MPEG4&nbsp; &nbsp; &nbsp; &nbsp; || stream_type==SERVICE_TYPE_VIDEO_H264 )&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; VideoPid pid;&nbsp; &nbsp; &nbsp; &nbsp; pid.Pid=elementary_PID;&nbsp; &nbsp; &nbsp; &nbsp; pid.VideoServiceType=stream_type;&nbsp; &nbsp; &nbsp; &nbsp; [B]m_pidInfo.videoPids.insert(m_pidInfo.videoPids.begin(), pid);[/B]&nbsp; &nbsp; &nbsp; }[/code]&nbsp;Not a particularly &quot;nice&quot; solution, but it works! <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink&nbsp; &nbsp; ;)" loading="lazy" data-shortname=";)" />And in fact, now that I think about it this is exactly the modification that I had in my TsReader to deal with the problem from --&gt;<a href="https://forum.team-mediaportal.com/threads/hd-channels-and-some-sd-channels-are-not-working.97296/" target="_blank">this</a>&lt;-- thread (similar issue). <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin&nbsp; &nbsp; :D" loading="lazy" data-shortname=":D" />&nbsp;Tony: the internal discussion about that thread that Rik refers to is --&gt;<a href="https://forum.team-mediaportal.com/threads/how-does-mp-handle-programs-with-multiple-video-streams.97310/" target="_blank">here</a>&lt;--. Interestingly, <a href="https://forum.team-mediaportal.com/threads/hd-channels-and-some-sd-channels-are-not-working.97296/#post-753429" target="_blank">the sample provided</a> now plays with audio and video (when the above tweak is applied). I think that is a testament to some great work that you've done in TsReader. You're a star mate! <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite24" alt="(y)" title="Thumbs Up&nbsp; &nbsp; (y)" loading="lazy" data-shortname="(y)" />I've now only got one other TS sample to hand that doesn't play correctly in MP...&nbsp;mm</blockquote>

[QUOTE="mm1352000, post: 886643, member: 82144"] Hmmm, problem seems to be that the stream with PID 0x30 (with stream type 0x80) is incorrectly detected as video. PmtParser.cpp: [code] if (stream_type==SERVICE_TYPE_DCII_OR_LPCM && !lpcm_audio_found) { VideoPid pid; pid.Pid=elementary_PID; pid.VideoServiceType=SERVICE_TYPE_VIDEO_MPEG2; m_pidInfo.videoPids.push_back(pid); }[/code] Obviously this is not a DC II stream, but in that context I don't know if we are able to distinguish properly. Anybody know anything about distinguishing between DC II and DVB MPEG transport streams? :D I can think of two possible "solutions": 1. Only allow one video PID to be recognised at the PMT parsing stage. Since the rest of the TsReader doesn't seem to support multiple video streams, this would likely be appropriate... although there is still the problem of selecting the correct PID. 2. TsReader is likely to be encountering DC II streams on a considerably (and increasingly) rarer basis than it would DVB streams... and DC II streams are also unlikely to have 2 video streams. We could prioritise the stream that we *know* is video over the stream that is possibly DC II video by doing the following: [code] if(stream_type==SERVICE_TYPE_VIDEO_MPEG1 || stream_type==SERVICE_TYPE_VIDEO_MPEG2 || stream_type==SERVICE_TYPE_VIDEO_MPEG4 || stream_type==SERVICE_TYPE_VIDEO_H264 ) { VideoPid pid; pid.Pid=elementary_PID; pid.VideoServiceType=stream_type; [B]m_pidInfo.videoPids.insert(m_pidInfo.videoPids.begin(), pid);[/B] }[/code] Not a particularly "nice" solution, but it works! ;) And in fact, now that I think about it this is exactly the modification that I had in my TsReader to deal with the problem from -->[URL='https://forum.team-mediaportal.com/threads/hd-channels-and-some-sd-channels-are-not-working.97296/']this[/URL]<-- thread (similar issue). :D Tony: the internal discussion about that thread that Rik refers to is -->[URL='https://forum.team-mediaportal.com/threads/how-does-mp-handle-programs-with-multiple-video-streams.97310/']here[/URL]<--. Interestingly, [URL='https://forum.team-mediaportal.com/threads/hd-channels-and-some-sd-channels-are-not-working.97296/#post-753429']the sample provided[/URL] now plays with audio and video (when the above tweak is applied). I think that is a testament to some [B]great work[/B] that you've done in TsReader. You're a star mate! (y) I've now only got one other TS sample to hand that doesn't play correctly in MP... mm [/QUOTE]

Verification