Reply to thread

Message

<blockquote data-quote="mm1352000" data-source="post: 887061" data-attributes="member: 82144">Hiya Tony&nbsp;Looks great to me. I'd be happy for that fix to go into 1.3b even without testing. Reasons being:1. Code looks okay. Isolated changes; not too much can go wrong.2. I think you're *very* unlikely to find a tester. TV Server's transponder files don't include DC II transponders, so it would have to be a very clued up person from North America with a very specific type of tuner (of which Genpix tuners are the most well known) and access to specific satellites to get DC II streams working in MP. Might be like finding a needle in a haystack. <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink&nbsp; &nbsp; ;)" loading="lazy" data-shortname=";)" />&nbsp;I guess if we are doing due diligence we should also think about fixing the detection upstream in TsWriter too. I note the comment in PmtParser.cpp:So ideally the PMT parsing code from TsReader should get into TsWriter rather than fixing DiskRecorder.cpp and PatParser.cpp. I think that is out of scope for MP 1.3b - too risky. Do you think we should still attempt a fix? Technically this could cause radio services to be detected as TV services...&nbsp;mm</blockquote>

[QUOTE="mm1352000, post: 887061, member: 82144"] Hiya Tony Looks great to me. I'd be happy for that fix to go into 1.3b even without testing. Reasons being: 1. Code looks okay. Isolated changes; not too much can go wrong. 2. I think you're *very* unlikely to find a tester. TV Server's transponder files don't include DC II transponders, so it would have to be a very clued up person from North America with a very specific type of tuner (of which Genpix tuners are the most well known) and access to specific satellites to get DC II streams working in MP. Might be like finding a needle in a haystack. ;) I guess if we are doing due diligence we should also think about fixing the detection upstream in TsWriter too. I note the comment in PmtParser.cpp: So ideally the PMT parsing code from TsReader should get into TsWriter rather than fixing DiskRecorder.cpp and PatParser.cpp. I think that is out of scope for MP 1.3b - too risky. Do you think we should still attempt a fix? Technically this could cause radio services to be detected as TV services... mm [/QUOTE]

Verification