[Finished] [MP2-820] Eject command for CD/DVD/Blu-ray disc media (1 Viewer)

henso

Development Group
  • Team MediaPortal
  • February 16, 2012
    2,341
    829
    Home Country
    Denmark Denmark
    Physical drives can also be USB DVD drives
    I added support for this, but I have no way to test it. It should check every 20 seconds.
    I think MP2 should handle ejecting during playback like stopping the playback (just before it ejects the disc).
    I added code for this, could you check?
     

    ge2301

    Lead Design MP2
  • Team MediaPortal
  • January 11, 2014
    8,705
    3,491
    Stuttgart
    Home Country
    Germany Germany
    I added code for this, could you check?
    (y) Works perfectly. This seems also to prevent the issue, when adding a DVD while MP2 is open. Before windows explorer popped up not accepting the disk, now it automatically starts to play.
     

    ge2301

    Lead Design MP2
  • Team MediaPortal
  • January 11, 2014
    8,705
    3,491
    Stuttgart
    Home Country
    Germany Germany
    Just pushed my last commit with EjectDiscButtonStyles in OSD for all skins. WMC skin and Nereus also have their side menu icon.
     

    HTPCSourcer

    Retired Team Member
  • Premium Supporter
  • May 16, 2008
    11,418
    2,335
    Home Country
    Germany Germany
    Just pushed my last commit with EjectDiscButtonStyles in OSD for all skins.
    You now display the button although no drive is present.
    EjectButton.jpg
     

    ge2301

    Lead Design MP2
  • Team MediaPortal
  • January 11, 2014
    8,705
    3,491
    Stuttgart
    Home Country
    Germany Germany
    You now display the button although no drive is present.
    That is always the case. The button is just a dublication of the menu entry, which does not know about about the existance of a drive I think. The problem is, that it should be visible only in the DVD OSD as for all other skins/themes. It seems I accidently placed it for Win10 theme into the VideoOSD or it's a combine style there. I'll take a look and fix it.

    Edit: Fixed and pushed.
     
    Last edited:

    ge2301

    Lead Design MP2
  • Team MediaPortal
  • January 11, 2014
    8,705
    3,491
    Stuttgart
    Home Country
    Germany Germany
    It does know. So it’s probably just a wrong assignment.
    Already fixed, but the button is always visible in DvDOSD.

    There is no IsVisible or IsEnabled property for the buttons. @henso is there a property I could bind to?
    The Play button is handled e.g. like following:
    XML:
    IsVisible="{Binding CanPlay}"
    MediaPortal/MediaPortal-2

    Edit: Well, probably the DvdOSD is never visible, if there is no disc tray, so the property might be useless :whistle:
     

    HTPCSourcer

    Retired Team Member
  • Premium Supporter
  • May 16, 2008
    11,418
    2,335
    Home Country
    Germany Germany
    I was kind of expecting that ;)

    My (industry) credo is that a 90% solution now is better than 100% sometimes in the future.
     

    Users who are viewing this thread

    Top Bottom