home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 2
Plugin Development
MP2 Audio Scan Tests
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="MJGraf" data-source="post: 1035871" data-attributes="member: 17886"><p>Let's start with the easy one: It compares the last modified dates of the files in the file system with the last import date of such file. If the file in the file system wasn't touched since the last import, it doesn't even open the file - which is why you don't see any file i/o <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin :D" loading="lazy" data-shortname=":D" /></p><p> </p><p></p><p>Well, the scan does not stop at a certain level, it obviously went into each subdirectory and imported all the audio files...</p><p>The particular problem you describe is caused by one thing not yet fully implemented: One album may have multiple "media" - in this case CDs. While our <a href="https://github.com/MediaPortal/MediaPortal-2/blob/master/MediaPortal/Source/Core/MediaPortal.Common/MediaManagement/DefaultItemAspects/AudioAspect.cs" target="_blank">AudioAspect </a>already has properties for "DiscID" and "NumDiscs", your AudioMetadataExtractor does not fill these properties, yet (have a look here, if you are interessted in what exactly is imported - I think it should be more or less "understandable" for non-devs although it is c#: <a href="https://github.com/MediaPortal/MediaPortal-2/blob/master/MediaPortal/Source/Extensions/MetadataExtractors/AudioMetadataExtractor/AudioMetadataExtractor.cs#L352" target="_blank">https://github.com/MediaPortal/MediaPortal-2/blob/master/MediaPortal/Source/Extensions/MetadataExtractors/AudioMetadataExtractor/AudioMetadataExtractor.cs#L352</a>). If this was implemented (which isn't too complicated) in your case NumDiscs should be 16 for all the audio files and DiscID should be 1, 2, ..., 16 depending on what disc the respective title is.</p><p>But even if we had this imported, it would require our MP2 Client media plugin to group albums by DiscID - at least when NumDiscs is greater than 1.I think this implementation is also missing - and since this involves the MP2 Client side and in particular skinning, I unfortunately can't help with that...</p><p> </p><p>But before implementing more and more into the AudioMetadataExtractor, maybe this is a good point to start a structured discussion of</p><ul> <li data-xf-list-type="ul">which sources should finally be used to import data for audio files? Besides directory structure/file name and tags I'm a big fan to get more data from MusicBrainz - but should this go into the AudioAspect? Should there be a separate MusicBrainzAspect?</li> <li data-xf-list-type="ul">We need an order of precedence regarding the sources</li> <li data-xf-list-type="ul">And of course we should be clear what properties we import</li> </ul><p>And this again brings us back to one problem, which (i think) chefkoch has already mentioned in the past: During an import, some information may be 100% certain (I would assume, info from tags is 100% certain - if not, the user should retag its files). But other information may not be 100% accurate (e.g. title names derived from file names). In this situation we may use online sources to make the info we have more accurate - but this may require user interaction (e.g. we guess an album name from the path name and then try to look it up in MusicBrainz. As a result, we may get three potential hits in MusicBrainz. The user must first choose, which hit is the right one, before we can import additional data. And therefore we need amendments to MP2 Client to make this possible...</p><p> </p><p>I thought about doing something in this area for quite some time. Maybe I should take this as next project after SQLite imporvements <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin :D" loading="lazy" data-shortname=":D" /> But I need help for the client side... And I should make up kind of a chart to show how exactly the import should work...</p><p> </p><p>One thing we also have to take into account here is configurability. Currently we have e.g. three hard-coded Regular Expressions in the code for guessing titles, etc. from path and file name. We should at least make these settings for now. Of course no "regular" user would touch regular expressions, but this would make it at least possible to later on offer some pre defined reg-exps for certain folder and sorting schemes.</p><p> </p><p></p><p>Nope, not really. You could issue a "select count (*) from M_MediaItem" to the database with some kind of SQLite database frontend. This returns you the total number of MediaItems in the library. But this includes everything: videos, movies, series, pictures and audio files and I think it even includes folders (not 100% sure about that...).</p><p> </p><p></p><p>That's already more or less the case for local shares (at least you get a notification when the import has completed), but not (yet) for global shares. But you're right, would be nice to have...</p><p> </p><p></p><p>Good idea - your personal wiki space is a perfect place for this. Log on to the wiki and you should see "My Page" in the upper left.</p></blockquote><p></p>
[QUOTE="MJGraf, post: 1035871, member: 17886"] Let's start with the easy one: It compares the last modified dates of the files in the file system with the last import date of such file. If the file in the file system wasn't touched since the last import, it doesn't even open the file - which is why you don't see any file i/o :D Well, the scan does not stop at a certain level, it obviously went into each subdirectory and imported all the audio files... The particular problem you describe is caused by one thing not yet fully implemented: One album may have multiple "media" - in this case CDs. While our [URL='https://github.com/MediaPortal/MediaPortal-2/blob/master/MediaPortal/Source/Core/MediaPortal.Common/MediaManagement/DefaultItemAspects/AudioAspect.cs']AudioAspect [/URL]already has properties for "DiscID" and "NumDiscs", your AudioMetadataExtractor does not fill these properties, yet (have a look here, if you are interessted in what exactly is imported - I think it should be more or less "understandable" for non-devs although it is c#: [url]https://github.com/MediaPortal/MediaPortal-2/blob/master/MediaPortal/Source/Extensions/MetadataExtractors/AudioMetadataExtractor/AudioMetadataExtractor.cs#L352[/url]). If this was implemented (which isn't too complicated) in your case NumDiscs should be 16 for all the audio files and DiscID should be 1, 2, ..., 16 depending on what disc the respective title is. But even if we had this imported, it would require our MP2 Client media plugin to group albums by DiscID - at least when NumDiscs is greater than 1.I think this implementation is also missing - and since this involves the MP2 Client side and in particular skinning, I unfortunately can't help with that... But before implementing more and more into the AudioMetadataExtractor, maybe this is a good point to start a structured discussion of [LIST] [*]which sources should finally be used to import data for audio files? Besides directory structure/file name and tags I'm a big fan to get more data from MusicBrainz - but should this go into the AudioAspect? Should there be a separate MusicBrainzAspect? [*]We need an order of precedence regarding the sources [*]And of course we should be clear what properties we import [/LIST] And this again brings us back to one problem, which (i think) chefkoch has already mentioned in the past: During an import, some information may be 100% certain (I would assume, info from tags is 100% certain - if not, the user should retag its files). But other information may not be 100% accurate (e.g. title names derived from file names). In this situation we may use online sources to make the info we have more accurate - but this may require user interaction (e.g. we guess an album name from the path name and then try to look it up in MusicBrainz. As a result, we may get three potential hits in MusicBrainz. The user must first choose, which hit is the right one, before we can import additional data. And therefore we need amendments to MP2 Client to make this possible... I thought about doing something in this area for quite some time. Maybe I should take this as next project after SQLite imporvements :D But I need help for the client side... And I should make up kind of a chart to show how exactly the import should work... One thing we also have to take into account here is configurability. Currently we have e.g. three hard-coded Regular Expressions in the code for guessing titles, etc. from path and file name. We should at least make these settings for now. Of course no "regular" user would touch regular expressions, but this would make it at least possible to later on offer some pre defined reg-exps for certain folder and sorting schemes. Nope, not really. You could issue a "select count (*) from M_MediaItem" to the database with some kind of SQLite database frontend. This returns you the total number of MediaItems in the library. But this includes everything: videos, movies, series, pictures and audio files and I think it even includes folders (not 100% sure about that...). That's already more or less the case for local shares (at least you get a notification when the import has completed), but not (yet) for global shares. But you're right, would be nice to have... Good idea - your personal wiki space is a perfect place for this. Log on to the wiki and you should see "My Page" in the upper left. [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 2
Plugin Development
MP2 Audio Scan Tests
Contact us
RSS
Top
Bottom