Reply to thread

Message

<blockquote data-quote="RoChess" data-source="post: 1219134" data-attributes="member: 18896">[USER=50218]@Recma[/USER], found problem.First off you changed the XML syntax, and moved value attribute to a different position, which causes the RegExp to fail and consider the file corrupt with default values being used. I'm not using an XML processor to read the file, but a raw solution, so to prevent failure/crashes I have to sanitize the input via Regular Expression.But the RegExp would have failed anyway, because the valid values I look for are \w{12,} which allows a-z, A-Z, 0-9, and underscores, but I did not account for '-' in the MPDb key.Also looking for 12 chars minimum seems a little extreme if a user has a short username, so I will change that to include hyphens, and lower it to 4+But you do have to fix your XML file back to the correct syntax of: &lt;set[\t\s]+id=&quot;\d+&quot;[\t\s]+name=&quot;global_options_[^&quot;]+&quot;[\t\s]+value=&quot;(?:true|false|[\w-]{12,})&quot;[\t\s]*/&gt;Example: &lt;set id=&quot;00&quot; name=&quot;global_options_xxxxx&quot; value=&quot;some&quot; /&gt;, but TABs are allowed, so if you like all your &quot;values&quot; to be lined up, just insert TABs.Original file not touched in 4 years @ <a href="https://raw.githubusercontent.com/RoChess/IMDbPlus/master/Options%20IMDb%2B%20Scraper.xml" target="_blank">https://raw.githubusercontent.com/RoChess/IMDbPlus/master/Options IMDb+ Scraper.xml</a>v4.9.72 is released that fixes the '-' and lowers it to 4+ chars, but you will need to fix your XML.</blockquote>

[QUOTE="RoChess, post: 1219134, member: 18896"] [USER=50218]@Recma[/USER], found problem. First off you changed the XML syntax, and moved value attribute to a different position, which causes the RegExp to fail and consider the file corrupt with default values being used. I'm not using an XML processor to read the file, but a raw solution, so to prevent failure/crashes I have to sanitize the input via Regular Expression. But the RegExp would have failed anyway, because the valid values I look for are \w{12,} which allows a-z, A-Z, 0-9, and underscores, but I did not account for '-' in the MPDb key. Also looking for 12 chars minimum seems a little extreme if a user has a short username, so I will change that to include hyphens, and lower it to 4+ But you do have to fix your XML file back to the correct syntax of: <set[\t\s]+id="\d+"[\t\s]+name="global_options_[^"]+"[\t\s]+value="(?:true|false|[\w-]{12,})"[\t\s]*/> Example: <set id="00" name="global_options_xxxxx" value="some" />, but TABs are allowed, so if you like all your "values" to be lined up, just insert TABs. Original file not touched in 4 years @ [B][URL]https://raw.githubusercontent.com/RoChess/IMDbPlus/master/Options%20IMDb%2B%20Scraper.xml[/URL][/B] v4.9.72 is released that fixes the '-' and lowers it to 4+ chars, but you will need to fix your XML. [/QUOTE]

Verification