Reply to thread

Message

<blockquote data-quote="sa_ddam213" data-source="post: 1080919" data-attributes="member: 89205">[USER=48781]@BassFan[/USER] First to you THANK YOU for helping with the plugin <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />Sorry to everyone who has been waiting for me to finish my house repairs, but that's the problem when there is only one developer on a plugin <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite3" alt=":(" title="Frown&nbsp; &nbsp; :(" loading="lazy" data-shortname=":(" />Anyway I am looking into the image issue, Really not sure what would be causing the issue as the plugin just reads a file off disk and displays it, there is no magic logic involved.I don't remember putting in a specific fix for modified images, I will have to try reproduce the error.The way images work is:In the plugin, if you are running MPDisplay on the same PC and MP the plugin will send the filename to MPDisplay to render on screen<a href="https://github.com/saddam213/MPDisplay" target="_blank">MPDisplay</a> / <a href="https://github.com/saddam213/MPDisplay/tree/master/MediaPortalPlugin" target="_blank">MediaPortalPlugin</a> / ImageHelper.cs [CODE=C#]&nbsp; &nbsp; public static class ImageHelper&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; public static APIImage CreateImage(string filename)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; string imageFile = File.Exists(filename)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ? filename : GUIGraphicsContext.GetThemedSkinFile(&quot;\\media\\&quot; + filename);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (RegistrySettings.InstallType == MPDisplayInstallType.Full)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return new APIImage(imageFile);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return new APIImage(FileHelpers.ReadBytesFromFile(imageFile));&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; }[/CODE]On the MPDisplay side it is rendered as a BitmapImage(<a href="https://github.com/saddam213/MPDisplay" target="_blank">MPDisplay</a> / <a href="https://github.com/saddam213/MPDisplay/tree/master/GUIFramework" target="_blank">GUIFramework</a> / <a href="https://github.com/saddam213/MPDisplay/tree/master/GUIFramework/Managers" target="_blank">Managers</a> / GUIImageManager.cs)[code]&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;summary&gt;&nbsp; &nbsp; &nbsp; &nbsp; /// Gets a BitmapImage from tshe specified filename.&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;/summary&gt;&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;param name=&quot;filename&quot;&gt;The filename.&lt;/param&gt;&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;returns&gt;&lt;/returns&gt;&nbsp; &nbsp; &nbsp; &nbsp; public static BitmapImage GetImage(string filename)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (!string.IsNullOrWhiteSpace(filename) &amp;&amp; File.Exists(filename))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; BitmapImage bmImage = new BitmapImage();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bmImage.BeginInit();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; //&nbsp; bmImage.DecodePixelWidth = GetScaledImageWidth(filename);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bmImage.CacheOption = BitmapCacheOption.None;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bmImage.UriSource = new Uri(filename, UriKind.RelativeOrAbsolute);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bmImage.EndInit();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bmImage.Freeze();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return bmImage;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; catch (Exception ex)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Log.Exception(&quot;[GetImage] - An exception occured creating BitmapImage&quot;, ex);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return new BitmapImage();&nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;summary&gt;&nbsp; &nbsp; &nbsp; &nbsp; /// Gets a BitmapImage from a set of image bytes.&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;/summary&gt;&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;param name=&quot;bytes&quot;&gt;The bytes.&lt;/param&gt;&nbsp; &nbsp; &nbsp; &nbsp; /// &lt;returns&gt;&lt;/returns&gt;&nbsp; &nbsp; &nbsp; &nbsp; public static BitmapImage GetImage(byte[] bytes)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (bytes != null &amp;&amp; bytes.Length &gt; 0)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; BitmapImage image = new BitmapImage();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; using (MemoryStream stream = new MemoryStream(bytes, false))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; image.BeginInit();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;&nbsp; // image.DecodePixelWidth = GetScaledImageWidth(bytes);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; image.CacheOption = BitmapCacheOption.None;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; image.StreamSource = stream;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; image.EndInit();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; image.Freeze();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; bytes = null;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; stream.Flush();&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return image;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; catch (Exception ex)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Log.Exception(&quot;[GetImage] - An exception occured creating BitmapImage&quot;, ex);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return new BitmapImage();&nbsp; &nbsp; &nbsp; &nbsp; }[/code]As you can see there is not anything extra done to images during creation.The only thing I could think of would be DPI or Depth, but reading the forum it seems you have checked this.I need to re-install my development environment this weekend (all filled with dust, LOL) and will see if I can add something, but if you can try different formats, dpi, color palate, depth as well we may be able to avoid custom code for custom images <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />With the majority(not all) of the repairs to my house done I will have some time for MPDisplay again, and will have more and more time as the repairs are finished. So progress may be still slow on the plugin (I don't even know what's changed in MP 1.7 yet)sa_ddam213</blockquote>

[QUOTE="sa_ddam213, post: 1080919, member: 89205"] [USER=48781]@BassFan[/USER] First to you THANK YOU for helping with the plugin :) Sorry to everyone who has been waiting for me to finish my house repairs, but that's the problem when there is only one developer on a plugin :( Anyway I am looking into the image issue, Really not sure what would be causing the issue as the plugin just reads a file off disk and displays it, there is no magic logic involved. I don't remember putting in a specific fix for modified images, I will have to try reproduce the error. The way images work is: In the plugin, if you are running MPDisplay on the same PC and MP the plugin will send the filename to MPDisplay to render on screen [URL='https://github.com/saddam213/MPDisplay'][U]MPDisplay[/U][/URL] / [URL='https://github.com/saddam213/MPDisplay/tree/master/MediaPortalPlugin'][U]MediaPortalPlugin[/U][/URL] / [B]ImageHelper.cs[/B] [CODE=C#] public static class ImageHelper { public static APIImage CreateImage(string filename) { string imageFile = File.Exists(filename) ? filename : GUIGraphicsContext.GetThemedSkinFile("\\media\\" + filename); if (RegistrySettings.InstallType == MPDisplayInstallType.Full) { return new APIImage(imageFile); } return new APIImage(FileHelpers.ReadBytesFromFile(imageFile)); } } [/CODE] On the MPDisplay side it is rendered as a BitmapImage ([URL='https://github.com/saddam213/MPDisplay'][U]MPDisplay[/U][/URL] / [URL='https://github.com/saddam213/MPDisplay/tree/master/GUIFramework'][U]GUIFramework[/U][/URL] / [URL='https://github.com/saddam213/MPDisplay/tree/master/GUIFramework/Managers'][U]Managers[/U][/URL] / [B]GUIImageManager.cs)[/B] [code] /// <summary> /// Gets a BitmapImage from tshe specified filename. /// </summary> /// <param name="filename">The filename.</param> /// <returns></returns> public static BitmapImage GetImage(string filename) { try { if (!string.IsNullOrWhiteSpace(filename) && File.Exists(filename)) { BitmapImage bmImage = new BitmapImage(); bmImage.BeginInit(); // bmImage.DecodePixelWidth = GetScaledImageWidth(filename); bmImage.CacheOption = BitmapCacheOption.None; bmImage.UriSource = new Uri(filename, UriKind.RelativeOrAbsolute); bmImage.EndInit(); bmImage.Freeze(); return bmImage; } } catch (Exception ex) { Log.Exception("[GetImage] - An exception occured creating BitmapImage", ex); } return new BitmapImage(); } /// <summary> /// Gets a BitmapImage from a set of image bytes. /// </summary> /// <param name="bytes">The bytes.</param> /// <returns></returns> public static BitmapImage GetImage(byte[] bytes) { try { if (bytes != null && bytes.Length > 0) { BitmapImage image = new BitmapImage(); using (MemoryStream stream = new MemoryStream(bytes, false)) { image.BeginInit(); // image.DecodePixelWidth = GetScaledImageWidth(bytes); image.CacheOption = BitmapCacheOption.None; image.StreamSource = stream; image.EndInit(); image.Freeze(); bytes = null; stream.Flush(); } return image; } } catch (Exception ex) { Log.Exception("[GetImage] - An exception occured creating BitmapImage", ex); } return new BitmapImage(); } [/code] As you can see there is not anything extra done to images during creation. The only thing I could think of would be DPI or Depth, but reading the forum it seems you have checked this. I need to re-install my development environment this weekend (all filled with dust, LOL) and will see if I can add something, but if you can try different formats, dpi, color palate, depth as well we may be able to avoid custom code for custom images :) With the majority(not all) of the repairs to my house done I will have some time for MPDisplay again, and will have more and more time as the repairs are finished. So progress may be still slow on the plugin (I don't even know what's changed in MP 1.7 yet) sa_ddam213 [/QUOTE]

Verification