My Lyrics 0.21 - Comments and bug reporting (1 Viewer)

idioteque

Retired Team Member
  • Premium Supporter
  • September 29, 2005
    609
    9
    Home Country
    Netherlands Netherlands
    I have a small skin issue

    the next page info is placed somewhat weird, should be next to lyrics txt instead of upon title in right corner
     

    mackey

    Retired Team Member
  • Premium Supporter
  • May 1, 2006
    456
    177
    right there
    Home Country
    Denmark Denmark
    Hi mackey,

    did some extensive testing this morning on the plugin.

    Crashes of the lyrics search:

    First time this morning the search went through without crash.
    After that, I got constantly windows exeptions for configuration.exe (while lyrics search seemed to continue)
    Once I had a cpu load of 100%.
    There is absolutely nothing in any log about the crash
    (searched mylyrics.log/mylyricsbatch.log/configuration.log)
    Once I "managed" to produce an "unhandled exeption" of the plugin after the windows exception notification came up. Still nothing in any of the logs.
    The search was started with the default options or only on marked songs. It also crashed on searching a lyric for a single song from the marked database.
    Also deleted the marked database. Made no difference.

    no lyrics change on song change

    can confirm that lyrics don´t change here on song change, as reported by others. Album and artist pictures aren´t updated either.
    When you leave the lyricsscreen and reenter, everything is updated.
    Using B2 4:3, scrobble on

    Edit: Seems to be more complicated. I have seen three behaviours:

    # no song lyrics and cover-art update on song change (most of the time)
    # display: " no song is playing" (but there is) (on some songs)
    # changing lyrics as it should (seen once only)

    search stats

    I would have sworn that the song search count was dynamic.

    I somewhat focused on this and the more I investigated, the stranger the stats became.

    My setup: my music database holds 5,985 thorougly tagged songs.
    The mylyrics database says it has lyrics for 5,661 songs.
    I estimate, that 3,000-4,000 mp3s have lyrics inside their tags.

    Now 5,985 - 5,661 = 324 songs without lyrics.
    A search with the default options gives:

    Total songs: 5,985
    Songs with lyrics: 5,750
    Songs with mark: 89
    Songs to search: 0
    Disregarded: 59

    1)
    Accidently I reran this search which I only had performed the other day, so that "songs nto search" 0 was correct.
    --> 5,750 > 5,661
    Just realizing while writing this, that 5,661 + 89 = 5,750.
    Q: Shouldn´t be there 324 marked songs (or 324-59)
    Q: If songs for which no lyrics could be found get marked, they can´t be counted for "songs with lyrics", can they?


    2)
    After this I unchecked "disregard previously marked songs". This gave me these stats:

    Total songs: 5,985
    Songs with lyrics: 5,742
    Songs with mark: 97
    Songs to search:
    Disregarded: 59

    There is a delta of 8 songs (5,750/5,742 and 89/97)


    3)
    Now I changed to marked only
    (cannot remember if 2) found additional lyrics)

    this showed now 113 songs to search
    the search found a lot of lyric
    it marked 36, found 60 and the search stopped at these 96 songs, it did not finish and never reached the 113. I stopped it manually.

    4)
    I deleted the marked database

    Total songs: 5,985
    Songs with lyrics: 5,742
    Songs with mark: 0
    Songs to search: 20
    Disregarded: 59

    -> it only showed 20 songs to search (Crashed a couple of times)

    5)
    Disregarded songs

    This was a constant figure: it was allways 59.
    According to the options, this number should contain
    "Disregard songs with lyrics in database"
    "Disregard songs with lyrics in mp3"
    and "Disregard songs by "various artists"

    as stated the lyrics database says it contains 5,661 lyrics,
    3,000-4,000 of my mp3´s contain lyrics in the tags
    According to MP artist view, I have not one song by "various artists"
    --> either it should be 5,661
    --> or label should be "disregarded songs by "various artists"
    --> still no clue where the 59 count in my case comes from.

    Mackey, this is all not really important, the functionality is the important thing and this is excellent. But I am a bit of a statistics freak :)
    Maybe this helps to narrow the issues down. If I can check anything else for you, give me a yell.

    tomtom


    Hi tomtom

    Thanks a lot for the thoroughly report on the stats. I can understand that you are quite confused about the numbers shown. Some of the confusing is caused by a couple of bugs that I now has sorted and fixed.

    Or rather I have found three bugs;
    #1: one bug causing the lyric engine to crash when closing a specific search
    #2: another bug causing files with lyric information to be disconsidered in various ways.
    #3: 2-3 of the lyrics sites at times fail to deliver an answer to the requests of the plugin, and not responding/updating the stats of the lyrics engine.

    The fix for #1 should certainly make the plugin stable as rock once again. The bug also caused the GUI to crash on the MyLyrics screen. I haven't had a single crash since I found a handle error, so everything should once again be smooth running in release 0.22.

    The number of music files with a lyric in the tag is added to the "Songs with lyric". They are not added to the "Disgarded" value as the name of the checkboxes might trick you to believe. The disregarded value is incremented when a lyric either has "Unknown" as artist or "Various artists" as artist tag and the "disregard songs by various artists" checked.

    The bug described in #3 caused some requests to lyric sites to freeze and never return a value. That way the lyrics engine never got an update and it couldn't say that the search was a success or a failure. This explains that the batch search suddenly don't update anymore, and not reaching the number of lyrics to search. It also explains the high cpu load, since 100 of processes could be left waiting for a answer to the request and accordingly never be aborted.

    When that is said, there is a couple of things to have in mind when considered the stats of the search:
    1. The counting of the various values stops when the number of lyrics to search has been reaches. That explains the delte of 8 songs in 2)
    2. Tracks with identical tag information only counts as one track in the statistics. Due to performance issues I don't store information of which tracks that have been search in a each search, so there is no way to tell if a specific artist+title combination already has been searched. So, the numbers in the stats will in many cases be less that the actuall number.

    Thanks again for testing. A new release is likely to be released sunday.
     

    mackey

    Retired Team Member
  • Premium Supporter
  • May 1, 2006
    456
    177
    right there
    Home Country
    Denmark Denmark
    I have a small skin issue

    the next page info is placed somewhat weird, should be next to lyrics txt instead of upon title in right corner
    I agree that they are placed rather strangely but I cannot seem to place the tabs in a proper position any longer. I use the <SpinPosX> and <SpinPosY> tags in the xml file but they seem to have lost their effect. Any help is appreciated.
     

    dapun

    Portal Pro
    October 1, 2007
    58
    0
    Issue with MediaPortal_0.2.3_RC2 and svn--10-03-2007--01-02-Rev16098.

    Hey Mackey...

    Hope you can help I am trying to load up My Lyrics's .22 and I can enable it in Media Portal Configuration, but when I try to do Configuration on the plugin I get the following Error. "Unhandle exception has occured in your application. If you click continue, the application will ignore the error and attempt to continue. If you click Quite, the application will close immediately." MediaPortal.Music.Database.MusicDatabase.ctor().
    This is from the Details Button...
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    See the end of this message for details on invoking
    just-in-time (JIT) debugging instead of this dialog box.

    ************** Exception Text **************
    System.MethodAccessException: MediaPortal.Music.Database.MusicDatabase..ctor()
    at MyLyrics.MyLyricsSetup..ctor()
    at MyLyrics.GUIMyLyrics.ShowPlugin()
    at MediaPortal.Configuration.Sections.PluginsNew.itemConfigure_Click(Object sender, EventArgs e)
    at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
    at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
    at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
    at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
    at System.Windows.Forms.ToolStripItem.FireEventInteractive(EventArgs e, ToolStripItemEventType met)
    at System.Windows.Forms.ToolStripItem.FireEvent(EventArgs e, ToolStripItemEventType met)
    at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
    at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
    at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
    at System.Windows.Forms.Control.WndProc(Message& m)
    at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
    at System.Windows.Forms.ToolStrip.WndProc(Message& m)
    at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
    at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
    at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
    at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


    ************** Loaded Assemblies **************
    mscorlib
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.832 (QFE.050727-8300)
    CodeBase: file:///C:/WINDOWS/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
    ----------------------------------------
    Configuration
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Configuration.exe
    ----------------------------------------
    System.Windows.Forms
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.832 (QFE.050727-8300)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
    ----------------------------------------
    System
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.832 (QFE.050727-8300)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
    ----------------------------------------
    System.Drawing
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.832 (QFE.050727-8300)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
    ----------------------------------------
    Core
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Core.DLL
    ----------------------------------------
    Utils
    Assembly Version: 2.2.2.0
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Utils.DLL
    ----------------------------------------
    System.Xml
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.832 (QFE.050727-8300)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Xml/2.0.0.0__b77a5c561934e089/System.Xml.dll
    ----------------------------------------
    BassRegistration
    Assembly Version: 1.0.0.0
    Win32 Version: 1.0.0.0
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/BassRegistration.DLL
    ----------------------------------------
    Databases
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Databases.DLL
    ----------------------------------------
    DirectShowLib
    Assembly Version: 1.4.0.0
    Win32 Version: 1.4.0.0
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/DirectShowLib.DLL
    ----------------------------------------
    System.ServiceProcess
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.ServiceProcess/2.0.0.0__b03f5f7f11d50a3a/System.ServiceProcess.dll
    ----------------------------------------
    System.Configuration
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.832 (QFE.050727-8300)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Configuration/2.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
    ----------------------------------------
    x0c6642u
    Assembly Version: 2.2.2.0
    Win32 Version: 2.0.50727.832 (QFE.050727-8300)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
    ----------------------------------------
    Microsoft.DirectX.Direct3D
    Assembly Version: 1.0.2902.0
    Win32 Version: 9.05.132.0000
    CodeBase: file:///C:/WINDOWS/assembly/GAC/Microsoft.DirectX.Direct3D/1.0.2902.0__31bf3856ad364e35/Microsoft.DirectX.Direct3D.dll
    ----------------------------------------
    Bass.Net
    Assembly Version: 2.3.1.2
    Win32 Version: 2.3.1.2
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Bass.Net.DLL
    ----------------------------------------
    RemotePlugins
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/RemotePlugins.DLL
    ----------------------------------------
    Microsoft.DirectX.DirectInput
    Assembly Version: 1.0.2902.0
    Win32 Version: 5.04.00.2904
    CodeBase: file:///C:/WINDOWS/assembly/GAC/Microsoft.DirectX.DirectInput/1.0.2902.0__31bf3856ad364e35/Microsoft.DirectX.DirectInput.dll
    ----------------------------------------
    Microsoft.DirectX
    Assembly Version: 1.0.2902.0
    Win32 Version: 5.04.00.2904
    CodeBase: file:///C:/WINDOWS/assembly/GAC/Microsoft.DirectX/1.0.2902.0__31bf3856ad364e35/Microsoft.DirectX.dll
    ----------------------------------------
    MPInstaller.Library
    Assembly Version: 0.0.0.0
    Win32 Version: 0.0.0.0
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/MPInstaller.Library.DLL
    ----------------------------------------
    System.Data
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.832 (QFE.050727-8300)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_32/System.Data/2.0.0.0__b77a5c561934e089/System.Data.dll
    ----------------------------------------
    CSScriptLibrary
    Assembly Version: 1.9.0.0
    Win32 Version: 1.9.0.0
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/CSScriptLibrary.DLL
    ----------------------------------------
    a456e687-6b21-4067-89c4-f1bff1b00795
    Assembly Version: 0.0.0.0
    Win32 Version: 0.0.0.0
    CodeBase: file:///C:/Documents%20and%20Settings/Pun/Local%20Settings/Temp/a456e687-6b21-4067-89c4-f1bff1b00795.tmp
    ----------------------------------------
    f4884160-b533-45cd-bd2c-fec2afff2710
    Assembly Version: 0.0.0.0
    Win32 Version: 0.0.0.0
    CodeBase: file:///C:/Documents%20and%20Settings/Pun/Local%20Settings/Temp/f4884160-b533-45cd-bd2c-fec2afff2710.tmp
    ----------------------------------------
    ec6d4072-ada3-4075-b635-034c05e0bce0
    Assembly Version: 0.0.0.0
    Win32 Version: 0.0.0.0
    CodeBase: file:///C:/Documents%20and%20Settings/Pun/Local%20Settings/Temp/ec6d4072-ada3-4075-b635-034c05e0bce0.tmp
    ----------------------------------------
    System.Runtime.Serialization.Formatters.Soap
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Runtime.Serialization.Formatters.Soap/2.0.0.0__b03f5f7f11d50a3a/System.Runtime.Serialization.Formatters.Soap.dll
    ----------------------------------------
    d4hx9gbx
    Assembly Version: 0.2.2.9991
    Win32 Version: 2.0.50727.832 (QFE.050727-8300)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
    ----------------------------------------
    TVCapture
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/TVCapture.DLL
    ----------------------------------------
    TaskScheduler
    Assembly Version: 1.1.1007.26951
    Win32 Version: 1.1.1007.26951
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/TaskScheduler.DLL
    ----------------------------------------
    System.Management
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.832 (QFE.050727-8300)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Management/2.0.0.0__b03f5f7f11d50a3a/System.Management.dll
    ----------------------------------------
    Interop.X10
    Assembly Version: 1.0.0.0
    Win32 Version: 1.0.0.0
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Interop.X10.DLL
    ----------------------------------------
    Dialogs
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Plugins/windows/Dialogs.DLL
    ----------------------------------------
    MP-TVSeries
    Assembly Version: 1.2.0.0
    Win32 Version: 1.2.0.0
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Plugins/windows/MP-TVSeries.dll
    ----------------------------------------
    MyLyrics
    Assembly Version: 0.22.0.0
    Win32 Version: 0.22
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Plugins/windows/MyLyrics.dll
    ----------------------------------------
    LyricsEngine
    Assembly Version: 0.22.0.0
    Win32 Version: 0.22.0.0
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/LyricsEngine.DLL
    ----------------------------------------
    WindowPlugins
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Plugins/windows/WindowPlugins.dll
    ----------------------------------------
    XihSolutions.DotMSN
    Assembly Version: 2.0.1.15051
    Win32 Version: 2.0.1.15051
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Plugins/windows/XihSolutions.DotMSN.DLL
    ----------------------------------------
    SubtitlePlugins
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Plugins/subtitle/SubtitlePlugins.dll
    ----------------------------------------
    TagReaderPlugins
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Plugins/tagreaders/TagReaderPlugins.dll
    ----------------------------------------
    ExternalPlayers
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Plugins/externalplayers/ExternalPlayers.dll
    ----------------------------------------
    Interop.iTunesLib
    Assembly Version: 1.7.0.0
    Win32 Version: 1.7.0.0
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/Interop.iTunesLib.DLL
    ----------------------------------------
    ProcessPlugins
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/plugins/process/ProcessPlugins.DLL
    ----------------------------------------
    MusicShareWatcherHelper
    Assembly Version: 0.2.2.9991
    Win32 Version: 0.2.2.9991
    CodeBase: file:///C:/Program%20Files/Team%20MediaPortal/MediaPortal/MusicShareWatcherHelper.DLL
    ----------------------------------------

    ************** JIT Debugging **************
    To enable just-in-time (JIT) debugging, the .config file for this
    application or computer (machine.config) must have the
    jitDebugging value set in the system.windows.forms section.
    The application must also be compiled with debugging
    enabled.

    For example:

    <configuration>
    <system.windows.forms jitDebugging="true" />
    </configuration>

    When JIT debugging is enabled, any unhandled exception
    will be sent to the JIT debugger registered on the computer
    rather than be handled by this dialog box.

    Your Assistance is greatly appreciated let me know if you need any information, I also tried this without the SVN and still got the error.

    Thanks.
     

    mackey

    Retired Team Member
  • Premium Supporter
  • May 1, 2006
    456
    177
    right there
    Home Country
    Denmark Denmark
    Hi. My developer computer has been down for some time, but I will hopefully have the time to buy a new one next week. Then I fix the plugin.
    best regards.
     

    sogge

    Portal Pro
    September 24, 2007
    107
    5
    60
    Home Country
    Spain Spain
    ..when I try to do Configuration on the plugin I get the following Error. "Unhandle exception has occured in your application. If you click continue, the application will ignore the error and attempt to continue. If you click Quite, the application will close immediately." MediaPortal.Music.Database.MusicDatabase.ctor()...

    same problem here with 0.2.3 RC2 SVN 16022
     

    mzemina

    Retired Team Member
  • Premium Supporter
  • February 23, 2005
    2,064
    14
    Tulsa, OK
    Home Country
    United States of America United States of America
    Too bad we can't chip-in to help mackey purchase a replacement development computer.
     

    mackey

    Retired Team Member
  • Premium Supporter
  • May 1, 2006
    456
    177
    right there
    Home Country
    Denmark Denmark
    Sorry for the delay.. too much work and other stuff is taking up all my time. I hope to be able to dig into the problem really soon. I expect a working version to be released next week.
     

    mzemina

    Retired Team Member
  • Premium Supporter
  • February 23, 2005
    2,064
    14
    Tulsa, OK
    Home Country
    United States of America United States of America
    Sorry for the delay.. too much work and other stuff is taking up all my time. I hope to be able to dig into the problem really soon. I expect a working version to be released next week.


    Hooray!!

    :D For the good words!
     

    mackey

    Retired Team Member
  • Premium Supporter
  • May 1, 2006
    456
    177
    right there
    Home Country
    Denmark Denmark
    I just made a quick fix to make the plugin work with 0.2.3.0 RC3. However I cannot seem to retrieve the number of songs in the new flat music database in less than 20 seconds, and that is too long to wait. So in the configuration the size of the music database is hardcoded as "30000". (I have asked rtv for help on this one)

    You can the beta of version 0.23 of MyLyrics here

    Note: there is currently no xml for XFace
     

    Users who are viewing this thread

    Top Bottom