MyLyrics 0.13 - Comments and bug reporting (1 Viewer)

[mackey]

Hi all

I have worked hard on the plugin the last week and made many changes in version 0.13. Most of these changes is inside the hood and is related to the performance and thread management. I am really happy with the outcome and my tests show that the lyricengine have got a needed boost in performance and also in realiability. But it is quite impossible to test everything and I bet there still is a couple of issues that I will have to consider to the next version.

This fixes and adds have purely been performance related, but also a new more reliable log has been introduced, it is called 'MyLyrics.log' and is to be found in the log-directory of the Mediaportal library (please attach this log to your post whenever it seems needed).

The focus until the next release will be finding bugs in the lrc-handling (I've already found a couple, see below), and hopefully there will be some time to add a couple of sites that can be accessed directly without a google search.

Finally, please report all the discovered bugs and comments to version 0.13 in this thread. In this way I hope the My Lyrics Plugin subforum will have a limited number of threads and wont become too messy. I will likewise note the bugs I find since the release at the end of this message.


***********************************

My Lyrics is a windows plugin for displaying the lyric of the current played music file in MediaPortal. All versions up to 0.2 is to be consider betas and will accordingly not be flawless or complete, but yet stable.

My Lyrics - version 0.13

Basic features:
- Dynamic search for lyric matching currently playing music file
- Batch search for lyrics matching songs in music database
- Add/delete/edit lyrics to database
- Reading of lyrics in music tags
- Support for lrc-files.
- Support for nine lyrics sites. Including LyricsWiki, that is, no google license required (but still recommended).

Changes from version 0.12 to 0.13:
- Add: Improved log. Logging search information in every session of MyLyric from MP starts to it closes. Saved in log\MyLyrics.log.
- Fix: All threads are now aborted as intended when search finishes. Both in configuration and play mode.
- Fix: Proper cleanup of trace objects and log files when configuration is closed.
- Fix: Lyrics searches optimized in regards to both speed and hit ration.
- Fix: Some threads ended up in deadlock when changing google license key.
- Fix: Sometimes when a lyric was found an unsuccessful, and not the succesful lyric site, was written to the MyLyrics.log.
- Add: MyLyric screen search now only uses lyric sites selected in the configuration.
- Fix: Exception messages (e.g. when license key is announced invalid for the day) is no longer shown on screen.
- Fix: Bad library handling caused the configuration in some circumstances to crash on when trying to access the MyLyricsBatch log-file.

This version holds dll's for both a clean MP 0.2.2.0 install (default) and the latest SVN build. See the readme.txt for install.

***********************************


Summary of this thread:
- Bug report #1 (by mackey): LRC-text saved in music tags aren't formatted correctly and accordingly shown as regular lyrics (Fixed, will be in version 0.14).
- Bug report #2 (by mackey): Text-fields and LRC-fields aren't reset before interpreting a new LRC-fields resulting in wrong timestamps and steady ""Searching for a matching lyric. Please wait a moment..."-message (Fixed, will be in version 0.14).

 

[Marcusb]

Great, thanks for all the hard work. I was sad when I had to choose between this plugin and the latest SVNs, but good news all around now

Pity I won't be able to try it until I am back hoe again...

 

[MEGA180]

May be one comment :
You should put Two folders inside your ZIP. One for 0.2.2.0 and one for svn. It would be easier to install. Because I had to delete the svn dll inside plugins/windows to get it work.

First Test :
I noticed a difference in scrolling when you stop it and rerun it, it starts again at the beginning of the song so it's better.

Thanks
Bye

 

[Sh4nn0w]

I've added a wiki page

Its a work in progress currently; Installation, Configuration & Usage to be completed.

Let me know if you want anything added/changed or of course anyone else is free work on it.

Great Plugin!

 

[Taipan]

I have worked hard on the plugin the last week and made many changes in version 0.13.

I have just started to use this plug-in and I am very impressed with all the work you have done – it is excellent ...

I have some queries:-

In Configuration -> Search Setup -> Lyric sites to search, there are 7 check boxes and LyricWiki is selected by default. If I select more than one site to search, will MyLyrics search the other sites if the lyrics cannot be found at the first one?

I have done some test Music database searches (100 songs at a time) and about 20% are not found using just LyricWiki - what do I need to do to get the missed songs updated by one of the other lyric sites?

I have had the error message “The search has ended due to no more valid license keys entries today” occur a couple of times when attempting a second or subsequent Music database search - I am not what it means or what I need to do?

Thanks ....

 

[Marcusb]

Hi Taipan, that message is from the Google search limitations.
Google only lets you perform 1000 (i think) searches per day on an extended search lisence key. There is a default one in the plugin, but that gets used up by all the people who haven't applied for their own.
You have two option, 1) disable Google searching or 2) (the best option) follow the instructions and apply for a Google Lisence. I'm away from home so don't have the instructions, but they should be in the plugin somewhere.

 

[mackey]

I have just started to use this plug-in and I am very impressed with all the work you have done – it is excellent ...

I have some queries:-

In Configuration -> Search Setup -> Lyric sites to search, there are 7 check boxes and LyricWiki is selected by default. If I select more than one site to search, will MyLyrics search the other sites if the lyrics cannot be found at the first one?

I have done some test Music database searches (100 songs at a time) and about 20% are not found using just LyricWiki - what do I need to do to get the missed songs updated by one of the other lyric sites?

I have had the error message “The search has ended due to no more valid license keys entries today” occur a couple of times when attempting a second or subsequent Music database search - I am not what it means or what I need to do?

Thanks ....

Hi! Yes, all checked lyric sites are searched asynch. LyricWiki gets a little headstart but is soon followed by the other checked sites in a prioritized turn. All the searches are encapsulated into their own thread for better performance.

Actually, if you don't already have a google license key there is not much you can do to improve your hit ratio of 80 percentage in the moment. Google has unfortunately stopped issuing new license keys, which is needed by the other site entries to find lyrics.

But is will soon be better; I'm incorporating a few more sites without google-depentency. I've already included EvilLabs and will do another one in the weekend, where I have some time. When the support of 2-3 more sites have been added I believe you will be able to find more songs than now. Another approach would be to use the new Microsoft live web service, which lets you perform 10.000 queries pr. day.

However not all songs have a matching lyric on the Net, so even if I added 100 new lyrics sites, I would be quite surprised if all of your songs will be found.

 

[tomtom21000]

Last night I tested the plugin again and it worked very well.

Like Taipan i did 3 runs with 100 songs. google request were still available and I ticked 4-5 search engines. Everything worked very well, but the search never got to the end it allways sopped at the 95 to 97th song. Could be coincidence. I didn´t wait longer than 5 minutes, then cancelled (thanks for the button) the search.

I still wonder where you save the lyrics?

Your plugin reads the lyrics stored in the mp3 now. Wouldn´t it be good to add them to your database, too? I don´t think it is a performance thing (like with embedded cover art and list views) but consistency?

Your plugin can import .txt lyrics with add...
Now I tried a sw that puts the lyrics in the mp3 and (optional) creates a .txt file
If I wanted to add these I had to run through hundreds of folders, so maybe an add for folder and subfolders would be an idea?

As said, everything runs very good and the points above give no problem and the whole search is more or less a one time (from time to time) thing. Just wanted to share my little observations.

tomtom

 

[Marcusb]

Taipan, I can send you my license key to use if you need. I'm sure between the two of us we won't get to 1000 searches per day.
Just don't spread it around.
I won't be home for another week so can send then if you need. Just let me know.

 

[Taipan]

Taipan, I can send you my license key to use if you need.

Thanks Marcus, but I should be OK - luckily I applied for a key before Google stopped issuing them, so that should get me out of trouble ...