MyLyrics 0.13 - Comments and bug reporting (4 Viewers)

[Taipan]

not all songs have a matching lyric on the Net, so even if I added 100 new lyrics sites, I would be quite surprised if all of your songs will be found.

I did a bit of research on the songs where lyrics weren't found (as they belonged to an album where the other songs were found) and discovered that in most cases it was due to a slight spelling or punctuation error (a missing comma, for example) in the song title within the mp3 tag. I fixed the song title errors and the hit ratio is much, much better ...

 

[Taipan]

Unhandled exception error ...

I notice that sometimes when I run a search of 100 songs, the search will finish all 100 songs, but not issue the completed message - it seems to hang at that point so that the "Start" button remains greyed out. If I exit MediaPortal Setup and then launch it again to run MyLyrics Configuration, I get the following error:-



So, it looks like it is the "hung" MyLyrics process that is locking the MyLyrics.log file?

Do you know why it might be hanging at the end of a successful search?

Do you need any other information or log files from me?

EDIT:

Here's some more information on the error message. I just did 3 or 4 searches, of 100 songs each, in a row and the last search hung. I was not doing anything else on the PC during the searches. This is what the MyLyrics Configuration looks like at the point where it has hung:-



You can see that all 100 songs have been searched, but the "Start" and "Close" buttons are still greyed out ...

The only way I can continue is to exit MediaPortal Setup, and then re-boot the PC.

Also, notice that I have 2 Google license keys, one of which is usable, but the summary at the bottom says I am done for the day.

Cheers,

Taipan

 

[tomtom21000]

Bug report:

My lyrics search is not working.

# successfully searched for lyrics the other day
# in between closed mp and hibernated pc
# tried to find some more lyrics
# all disregard settings set
# google key usable
# on step 1: Collecting of songs has started 4,529 songs, 79 songs disregarded, all others 0 or "-"
--> my lyrics stops here
#left it for 20 minutes, no changes
#buttons and tabs still clickable
#cancel button does not cancel
# cpu load is 0 - 2 %
#memory usage of configuration.exe stays constant
#can only kill process to get out
# there is nothing in the logs (mylyrics.log created but empty. same with configuration.log, no error.log created)
# made no changes to system between successfully searching the other day and now (not sure about the lyrics search engines, but it seems it is not getting so far.
# it is constantly reproducable. Allways stops at disregard 79.
# no idea which song this would be. also no songs were added or deleted between the 2 days.
#drove system down and made a cold start of htpc. Made no difference.

Don´t know if these informations are of any help. If I can try anything or give more info just ask, please.

tomtom

 

[mackey]

Thanks tomtom21000 and Taipan for your testing and feedback. It is really appreciated, and a great help in fixing the small bugs that undoubtfully still is present in the current release.

tomtom21000
i) The lyricsengine have a quite complex structure with up to 30 searching running in their own thread. Each thread reports its outcome (if a lyric was found or not at a specific site) back to a controller class when it has finished. I thought all the issues of threads not ending and not giving a proper message to the controller class were all sorted out, but it seems like their still is a issues or two.

I'm currently making some refactoring of the different types of lyrics searches and will as a bonus obtain a clearer and better handling of threads. It will help me to find the problem, or perhaps the problem will be fixed in the refactoring-work itself. I will make another test when the refactoring is completed and fix any errors that I find.

ii) I save the lyrics in Lyrics.xml that is located in the MP directory.

iii) I cannot quite see the point in saving the lyrics from music tags in the database. At least now when there are no export of the xml or no other plugin is using it. However it might in the future and then it would be a good idea. But I'll put in on my todo-list.

iv) The wish for a directory-based .txt-add is also put on the todo-list. I see that the search for matching .txt-files in a direcory and subdirectories will be very handy when added a lot of files. The features will natural also be relevant for lrc-files.

 

[mackey]

I notice that sometimes when I run a search of 100 songs, the search will finish all 100 songs, but not issue the completed message - it seems to hang at that point so that the "Start" button remains greyed out. If I exit MediaPortal Setup and then launch it again to run MyLyrics Configuration

So, it looks like it is the "hung" MyLyrics process that is locking the MyLyrics.log file?

Do you know why it might be hanging at the end of a successful search?

Do you need any other information or log files from me?

...

Here's some more information on the error message. I just did 3 or 4 searches, of 100 songs each, in a row and the last search hung.

You can see that all 100 songs have been searched, but the "Start" and "Close" buttons are still greyed out ...

The only way I can continue is to exit MediaPortal Setup, and then re-boot the PC.

Also, notice that I have 2 Google license keys, one of which is usable, but the summary at the bottom says I am done for the day.

It seems like you are experincing a similar thing like tomtom21000. I will clean up the code and I believe that this will solve the problems with the search not ended properly.

However the search will end if you push the 'Cancel'-button. Thereby the MyLyrics.log will be closed and intended and you will not get the exception. I will though handle the log with a bit more care so the configuration wont hang if a similar thing arises in the future.

And yes, the summary at the bottom needs a little brush-up. I might be removed since the response of a google webservice don't always reveal the actual state.

thanks

 

[mackey]

Bug report:

My lyrics search is not working.

# successfully searched for lyrics the other day
# in between closed mp and hibernated pc
# tried to find some more lyrics
# all disregard settings set
# google key usable
# on step 1: Collecting of songs has started 4,529 songs, 79 songs disregarded, all others 0 or "-"
--> my lyrics stops here
#left it for 20 minutes, no changes
#buttons and tabs still clickable
#cancel button does not cancel
# cpu load is 0 - 2 %
#memory usage of configuration.exe stays constant
#can only kill process to get out
# there is nothing in the logs (mylyrics.log created but empty. same with configuration.log, no error.log created)
# made no changes to system between successfully searching the other day and now (not sure about the lyrics search engines, but it seems it is not getting so far.
# it is constantly reproducable. Allways stops at disregard 79.
# no idea which song this would be. also no songs were added or deleted between the 2 days.
#drove system down and made a cold start of htpc. Made no difference.

Don´t know if these informations are of any help. If I can try anything or give more info just ask, please.

tomtom

Hmm, I cannot quite figure out what causes the problem... If I get your music database-file I will try to reproduce the error. thanks

 

[armyofme]

Thanks Mackey for all your hard work on this fantastic plug in (which is easily my favourite - I just love singing along to songs!)

I, like Taipan and TomTom21000, have the same problem. The only thing I have noticed which fixes the problem is when I delete the Lyrics.xml file. But of course this starts me from the beginning again.

Armyofme

 

[mackey]

Thanks Mackey for all your hard work on this fantastic plug in (which is easily my favourite - I just love singing along to songs!)

I, like Taipan and TomTom21000, have the same problem. The only thing I have noticed which fixes the problem is when I delete the Lyrics.xml file. But of course this starts me from the beginning again.

Armyofme

Great that you like it I believe that I have fixed the errors mentioned above in the current development version. I cannot say when it will be released, because I still have a bit of testing to do and some stuff to implement before it will be suitable to put out.