Reply to thread

Message

@morpheus_xx
Hopefully my comment did not stopped you from improving the "NewsWidget"

@offbyone
I did a rebase of the news plugin with latest dev branch. You can compare
current news branch with dev: https://github.com/MediaPortal/MediaPortal-2/compare/dev...NewsPlugin
and rebased news branch with dev: https://github.com/MediaPortal/MediaPortal-2/compare/dev...NewsPlugin_Rebased

During the rebase I merge your intial commit and my fix for the solution file into one single commit.
I also removed the changes you have done in commit 2d13583 to FontAssetCore.cs. Replacement commit is 9f199c7.

Could you please check whether your changes in commit 2d13583 for FontAssetCore where still needed or if they are obsolete after the rework of the FontRendering, which was done already in dev-branch.

<blockquote data-quote="chefkoch" data-source="post: 956419" data-attributes="member: 10438">@<a href="https://forum.team-mediaportal.com/members/morpheus_xx.48495/" target="_blank">morpheus_xx</a>Hopefully my comment did not stopped you from improving the &quot;NewsWidget&quot; <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink&nbsp; &nbsp; ;)" loading="lazy" data-shortname=";)" />&nbsp;@<a href="https://forum.team-mediaportal.com/members/offbyone.73415/" target="_blank">offbyone</a>I did a rebase of the news plugin with latest dev branch. You can comparecurrent news branch with dev: <a href="https://github.com/MediaPortal/MediaPortal-2/compare/dev...NewsPlugin" target="_blank">https://github.com/MediaPortal/MediaPortal-2/compare/dev...NewsPlugin</a>and rebased news branch with dev: <a href="https://github.com/MediaPortal/MediaPortal-2/compare/dev...NewsPlugin_Rebased" target="_blank">https://github.com/MediaPortal/MediaPortal-2/compare/dev...NewsPlugin_Rebased</a>&nbsp;During the rebase I merge your <a href="https://github.com/MediaPortal/MediaPortal-2/commit/313346506adba2a1d7e38735fe93e684d2a91416" target="_blank">intial commit</a> and <a href="https://github.com/MediaPortal/MediaPortal-2/commit/e1675babe949f4182ee5a468d9879f894d56f027" target="_blank">my fix for the solution file</a> into <a href="https://github.com/MediaPortal/MediaPortal-2/commit/333beda69093d0c97c26340ae70f5b3418f07ac8" target="_blank">one single commit</a>.I also removed the changes you have done in <a href="https://github.com/MediaPortal/MediaPortal-2/commit/2d1358339bf5380da7f02a9a5bd14930eef6478f" target="_blank">commit 2d13583</a> to <a href="https://github.com/MediaPortal/MediaPortal-2/commits/2d1358339bf5380da7f02a9a5bd14930eef6478f/MediaPortal/Source/UI/SkinEngine/ContentManagement/AssetCore/FontAssetCore.cs" target="_blank">FontAssetCore.cs</a>. Replacement commit is <a href="https://github.com/MediaPortal/MediaPortal-2/commit/9f199c79669060d71e3355d57a7b05e660f0ea69" target="_blank">9f199c7</a>.&nbsp;Could you please check whether your changes in commit 2d13583 for FontAssetCore where still needed or if they are obsolete after the rework of the FontRendering, which was done already in dev-branch.</blockquote>

[QUOTE="chefkoch, post: 956419, member: 10438"] @[URL='https://forum.team-mediaportal.com/members/morpheus_xx.48495/']morpheus_xx[/URL] Hopefully my comment did not stopped you from improving the "NewsWidget" ;) @[URL='https://forum.team-mediaportal.com/members/offbyone.73415/']offbyone[/URL] I did a rebase of the news plugin with latest dev branch. You can compare current news branch with dev: [url]https://github.com/MediaPortal/MediaPortal-2/compare/dev...NewsPlugin[/url] and rebased news branch with dev: [url]https://github.com/MediaPortal/MediaPortal-2/compare/dev...NewsPlugin_Rebased[/url] During the rebase I merge your [URL='https://github.com/MediaPortal/MediaPortal-2/commit/313346506adba2a1d7e38735fe93e684d2a91416']intial commit[/URL] and [URL='https://github.com/MediaPortal/MediaPortal-2/commit/e1675babe949f4182ee5a468d9879f894d56f027']my fix for the solution file[/URL] into [URL='https://github.com/MediaPortal/MediaPortal-2/commit/333beda69093d0c97c26340ae70f5b3418f07ac8']one single commit[/URL]. I also removed the changes you have done in [URL='https://github.com/MediaPortal/MediaPortal-2/commit/2d1358339bf5380da7f02a9a5bd14930eef6478f']commit 2d13583[/URL] to [URL='https://github.com/MediaPortal/MediaPortal-2/commits/2d1358339bf5380da7f02a9a5bd14930eef6478f/MediaPortal/Source/UI/SkinEngine/ContentManagement/AssetCore/FontAssetCore.cs']FontAssetCore.cs[/URL]. Replacement commit is [URL='https://github.com/MediaPortal/MediaPortal-2/commit/9f199c79669060d71e3355d57a7b05e660f0ea69']9f199c7[/URL]. Could you please check whether your changes in commit 2d13583 for FontAssetCore where still needed or if they are obsolete after the rework of the FontRendering, which was done already in dev-branch. [/QUOTE]