[solved] No Fanart when playing (2 Viewers)

ajs

Development Group
  • Team MediaPortal
  • February 29, 2008
    16,069
    11,153
    Kyiv
    Home Country
    Ukraine Ukraine
    this build should fix double for thumbs
     

    Attachments

    • FanartHandler.dll.zip
      472.2 KB

    horned_reaper

    Test Group
  • Team MediaPortal
  • January 7, 2011
    1,233
    461
    Munich
    Home Country
    Germany Germany
    Change MBID for Marina and The... To correct...

    There's no MusicArtistThumbScraped record for "Marina And The Diamonds", only for "Marina". Marina has the correct MBID:
    1589473670758.png


    1589473479955.png
     

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    16,069
    11,153
    Kyiv
    Home Country
    Ukraine Ukraine
    Strange ... should present ... in new FH the some?

    Try change key1 ftom marina to marina and the diamonds and start palying :)
     

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    16,069
    11,153
    Kyiv
    Home Country
    Ukraine Ukraine
    I think problem this:
    Code:
    14-May-2020 07:10:55 Debug [             Scraper]: MusicBrainz: Trying to find MusicBrainz ID for Artist: Marina And The Diamonds.
    14-May-2020 07:10:55 Debug [             Scraper]: MusicBrainz: Extract ID: Empty
     

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    16,069
    11,153
    Kyiv
    Home Country
    Ukraine Ukraine
    For Marina And The Diamonds
    • MusicBrainz - no result
    • TheAudioDB - Marina and the Diamonds - 7f3d82ee-3817-4367-9eec-f33a312247a1
    • LastFM - Marina & the Diamonds - 7f3d82ee-3817-4367-9eec-f33a312247a1
    For this reason, the order of providers has always been: TheAudioDB, LastFM, MusicBrainz
    You have turned off other providers, so you do not have pictures for Marina And The Diamonds, something like this ... :):coffee::whistle:
     

    horned_reaper

    Test Group
  • Team MediaPortal
  • January 7, 2011
    1,233
    461
    Munich
    Home Country
    Germany Germany
    You're right, this is the root cause! (y)

    The MusicBrainz search API uses "and" as operator. Hence the MBID search for artists with "and" in their name fails with the current query format

    But I've found a solution! The MBID search on MusicBrainz works with the following format:
    http://musicbrainz.org/ws/2/artist/?query="Marina And The Diamonds"

    Not working (current format):
    http://musicbrainz.org/ws/2/artist/?query=artist:"Marina And The Diamonds"

    The "artist:" field name needs to be removed for "and" to work on artist searches.

    And the & character in the artist name needs to be replaced by %26 (URL Encoding). Working examples:
    Blank & Jones: http://musicbrainz.org/ws/2/artist/?query="Blank %26 Jones"
    Lexy & K-Paul: http://musicbrainz.org/ws/2/artist/?query="Lexy %26 K-Paul"

    The same applies to album (release group) searches, the & character needs to be replaced by %26 (URL Encoding). Working examples:
    http://musicbrainz.org/ws/2/release-group/?query=artist:"Marina And The Diamonds" AND release:"Electra Heart"
    http://musicbrainz.org/ws/2/release-group/?query=artist:"DJ Sakin %26 Friends" AND release:"Walk On Fire"
    http://musicbrainz.org/ws/2/release-group/?query=artist:"Warlock" AND release:"Triumph And Agony"

    Can we give this small change a try to further improve the MusicBrainz ID search?
    You will keep on supporting you on enhanced testing against my huge music collection. :)
     
    Last edited:

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    16,069
    11,153
    Kyiv
    Home Country
    Ukraine Ukraine
    The "artist:" field name needs to be removed for "and" to work on artist searches.
    And for Guns N'Roses to and for ... And for other options, therefore, it is necessary to return as it was, remove the artist: from the search for artists at all. :whistle:
    And the & character in the artist name needs to be replaced by %26 (URL Encoding).
    With all requests, the necessary characters are converted (URL Encoding) through the system function. :)
    Can we give this small change a try to further improve the MusicBrainz ID search?
    I can remove artist: from artist search, all other already in FH ... :coffee:
     

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    16,069
    11,153
    Kyiv
    Home Country
    Ukraine Ukraine
    Well, removing this, we get more false positives.
     

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    16,069
    11,153
    Kyiv
    Home Country
    Ukraine Ukraine

    ajs

    Development Group
  • Team MediaPortal
  • February 29, 2008
    16,069
    11,153
    Kyiv
    Home Country
    Ukraine Ukraine
    And this search return correct result ...
    Code:
    http://musicbrainz.org/ws/2/artist/?query=artist:"Marina & The Diamonds"
    Because there are more questions than answers, can it be easier to spell the right tags in the music?
     

    Users who are viewing this thread

    Top Bottom