Reply to thread

Message

<blockquote data-quote="ltfearme" data-source="post: 1095154" data-attributes="member: 52219">Good points [USER=52265]@TheBatfink[/USER], I didn't look closely enough at your log. Yes I would expect the error to appear in the trakt log file and have that error logged before it.Having a look at GUIWindow.LoadSkin() method in MediaPortal source shows there is some exception handling as well which writes out a stacktrace and shows that error:[CODE]// add thread check to log calls not running in main thread/GUI&nbsp; String threadName = Thread.CurrentThread.Name;&nbsp; if (threadName != &quot;MPMain&quot; &amp;&amp; threadName != &quot;Config Main&quot;)&nbsp; {&nbsp; Log.Error(&quot;LoadSkin: Running on wrong thread - StackTrace: '{0}'&quot;, Environment.StackTrace);&nbsp; }[/CODE]Obviously MediaPortal does not like entering that method on another thread which indeed is what is happening when loading a dashboard in the background. I won't be changing that, what it probably should not have done is even get that far, I think from having a look at the MediaPortal code it should of returned from GUIWindowManager.GetWindow after getting the window from the dictionary (why it was not there might have something to do with it being cleared...race condition / timing related...who knows without debugging).In retrospect it's probably a little overkill to have that while loop in trakt trying to get a reference to the facade (if the skin doesnt have the correct skinsettings it can get stuck for 100ms * 50 = 5 secs! So very important to have skin settings defined correctly. I might look at find a better way that using that loop, even when you do have it the facade defined in the window it might loop once or twice.I'll presume you won't ever see this issue (or atleast very slim chance) with the controls defined in windows that the skin tells the Trakt plugin about so see how you go with that. I suspect Titan would have the same problem if users remove Trakt from BasicHome but SkinSettings is not updated.</blockquote>

[QUOTE="ltfearme, post: 1095154, member: 52219"] Good points [USER=52265]@TheBatfink[/USER], I didn't look closely enough at your log. Yes I would expect the error to appear in the trakt log file and have that error logged before it. Having a look at GUIWindow.LoadSkin() method in MediaPortal source shows there is some exception handling as well which writes out a stacktrace and shows that error: [CODE] // add thread check to log calls not running in main thread/GUI String threadName = Thread.CurrentThread.Name; if (threadName != "MPMain" && threadName != "Config Main") { Log.Error("LoadSkin: Running on wrong thread - StackTrace: '{0}'", Environment.StackTrace); } [/CODE] Obviously MediaPortal does not like entering that method on another thread which indeed is what is happening when loading a dashboard in the background. I won't be changing that, what it probably should not have done is even get that far, I think from having a look at the MediaPortal code it should of returned from GUIWindowManager.GetWindow after getting the window from the dictionary (why it was not there might have something to do with it being cleared...race condition / timing related...who knows without debugging). In retrospect it's probably a little overkill to have that while loop in trakt trying to get a reference to the facade (if the skin doesnt have the correct skinsettings it can get stuck for 100ms * 50 = 5 secs! So very important to have skin settings defined correctly. I might look at find a better way that using that loop, even when you do have it the facade defined in the window it might loop once or twice. I'll presume you won't ever see this issue (or atleast very slim chance) with the controls defined in windows that the skin tells the Trakt plugin about so see how you go with that. I suspect Titan would have the same problem if users remove Trakt from BasicHome but SkinSettings is not updated. [/QUOTE]

Verification