Reply to thread

Message

<blockquote data-quote="vpupkin" data-source="post: 930650" data-attributes="member: 112198">Well, as in OV 1.2 YouTube-based sites stopped working, I had to re-visit this issue, and yep, it's still there for me - I can reproduce it on another machine. After re-compiling MP and OV, I traced null reference:&nbsp;[CODE]&nbsp; &nbsp; &nbsp; &nbsp; void g_Player_PlayBackEnded(g_Player.MediaType type, string filename)&nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; try&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (currentPlayingItem != null &amp;&amp; currentPlayingItem.Util != null)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; double percent = g_Player.Duration &gt; 0 ? g_Player.CurrentPosition / g_Player.Duration : 0;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; currentPlayingItem.Util.OnPlaybackEnded(currentPlayingItem.Video, currentPlayingItem.FileName, percent, false);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; catch (Exception ex)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; Log.Instance.Warn(&quot;Error on Util.OnPlaybackEnded: {0}&quot;, ex);&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (currentPlaylist != null)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (g_Player.Player.GetType().Assembly == typeof(GUIOnlineVideos).Assembly)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ...[/CODE]&nbsp;The last if has a problem for me, as at that point in time g_Player.Player is null (deleted too early?). Interestingly, if I remove the check, then playback of the next item in the list works just fine. Again, I am testing it on Comedy Central -&gt; Jon Stewart full episodes that happen to have several segments. After 1st segment is finished, this callback is invoked, and it crashes the whole MP for me.&nbsp;Any ideas how this case can be fixed? Thanks.</blockquote>

[QUOTE="vpupkin, post: 930650, member: 112198"] Well, as in OV 1.2 YouTube-based sites stopped working, I had to re-visit this issue, and yep, it's still there for me - I can reproduce it on another machine. After re-compiling MP and OV, I traced null reference: [CODE] void g_Player_PlayBackEnded(g_Player.MediaType type, string filename) { try { if (currentPlayingItem != null && currentPlayingItem.Util != null) { double percent = g_Player.Duration > 0 ? g_Player.CurrentPosition / g_Player.Duration : 0; currentPlayingItem.Util.OnPlaybackEnded(currentPlayingItem.Video, currentPlayingItem.FileName, percent, false); } } catch (Exception ex) { Log.Instance.Warn("Error on Util.OnPlaybackEnded: {0}", ex); } if (currentPlaylist != null) { if (g_Player.Player.GetType().Assembly == typeof(GUIOnlineVideos).Assembly) { ...[/CODE] The last if has a problem for me, as at that point in time g_Player.Player is null (deleted too early?). Interestingly, if I remove the check, then playback of the next item in the list works just fine. Again, I am testing it on Comedy Central -> Jon Stewart full episodes that happen to have several segments. After 1st segment is finished, this callback is invoked, and it crashes the whole MP for me. Any ideas how this case can be fixed? Thanks. [/QUOTE]

Verification