[Approved] Overflow in DVBSubtiles decoder on small packets (1 Viewer)

[thecode]

Hi,
I've noticed that under certain situations when a small PES packet is assembled (size less than 188 bytes) the DVB subtitles decoder will overflow, eventually crashing MP.
This packets are not regular DVB subtitle packets, but they exists in some DVB streams.
Tested on my machine.
Thanks.

 

[Holzi]

@tourettes you may have any idea about this?

 

[tourettes]

Sorry for the slow response.

Does those less than 188 byte packets contain padding?

 

[thecode]

Yes, the length field in the packet header declares a small size (e.g. 10 bytes).
Looking at the data the bytes declared by the length have data and the rest is padded by zeros.
I assume this packets are used to signal a special overlay icon on the DVB receiver.
anyway since the original code calculation always expects a packet longer than 188 bytes (which is usually the case for subtitle frames) the comparison in the code bellow will never get true:

if ( m_iPesLength == m_iWritePos  ) // we have the expected data

 

[thecode]

Hi,
Is there any way to move forward with this bug fix.
Many users in our community have to update the "DVBSub3.ax" manually after each release to prevent MP from crashing.
The patch only fix a bug and will not do anything to the code flow for users which are not affected by it.
Thanks

 

[Sebastiii]

Thanks for reminder, do we have a jira for this ?
We need to setup Jira + branch othervise it will get lost
@HomeY i tag you because you have skill with Jira

 

[HomeY]

MP1-4402: Overflow in DVBSubtiles decoder on small packets

@thecode Could you create a new patch? It fails (probably because of (recent) changes).

 

[Sebastiii]

Patch added to the branch

 

[Sebastiii]

Installer updated in Jira :
https://issues.team-mediaportal.com/browse/MP1-4402

Please test and confirm that it's ok (i will update Jira with answer)
@thecode

 

[Sebastiii]

@thecode
If no testing -> will not be include in next final release.