[Approved] Overflow in DVBSubtiles decoder on small packets (1 Viewer)

thecode

Portal Member
March 4, 2011
9
6
Israel Israel
Hi,
I've noticed that under certain situations when a small PES packet is assembled (size less than 188 bytes) the DVB subtitles decoder will overflow, eventually crashing MP.
This packets are not regular DVB subtitle packets, but they exists in some DVB streams.
Tested on my machine.
Thanks.
 

Attachments

thecode

Portal Member
March 4, 2011
9
6
Israel Israel
Yes, the length field in the packet header declares a small size (e.g. 10 bytes).
Looking at the data the bytes declared by the length have data and the rest is padded by zeros.
I assume this packets are used to signal a special overlay icon on the DVB receiver.
anyway since the original code calculation always expects a packet longer than 188 bytes (which is usually the case for subtitle frames) the comparison in the code bellow will never get true:
Code:
if ( m_iPesLength == m_iWritePos  ) // we have the expected data
 

thecode

Portal Member
March 4, 2011
9
6
Israel Israel
Hi,
Is there any way to move forward with this bug fix.
Many users in our community have to update the "DVBSub3.ax" manually after each release to prevent MP from crashing.
The patch only fix a bug and will not do anything to the code flow for users which are not affected by it.
Thanks
 
Last edited:

Sebastiii

Development Group
  • Team MediaPortal
  • November 12, 2007
    16,447
    10,273
    France
    France France
    Country flag
    Thanks for reminder, do we have a jira for this ?
    We need to setup Jira + branch othervise it will get lost :)
    @HomeY i tag you because you have skill with Jira :)
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    Top Bottom