[ Patch ] Allow disabling unwanted zoom modes (1 Viewer)

[cpp2005]

I just tried it and I don't see allowed zoom modes, not in design mode and not in compiled version.
The code for controls you added is inside InitializeComponent(), which is special method:
/// <summary>
/// Required method for Designer support - do not modify
/// the contents of this method with the code editor.
/// </summary>
As I understand this code is generated by designer, which stores it's data in .resx files. May be something more need to be done before compilation?

 

[ziphnor]

InitializeComponent is in for example Television.cs (starting on line 126) , not in an resx file.

Just to be sure you took the files from the patch and applied them to an updated SVN checkout and you see no mention of allowed zoom modes?

Among the member fields you should see:
private MediaPortal.UserInterface.Controls.MPGroupBox gAllowedModes;
private MediaPortal.UserInterface.Controls.MPCheckBox cbAllowNormal;
private MediaPortal.UserInterface.Controls.MPCheckBox cbAllowZoom149;
private MediaPortal.UserInterface.Controls.MPCheckBox cbAllowOriginal;
private MediaPortal.UserInterface.Controls.MPCheckBox cbAllowZoom;
private MediaPortal.UserInterface.Controls.MPCheckBox cbAllowLetterbox;
private MediaPortal.UserInterface.Controls.MPCheckBox cbAllowStretch;
private MediaPortal.UserInterface.Controls.MPCheckBox cbAllowPanScan;

And in initialize component you should have:
this.gAllowedModes = new MediaPortal.UserInterface.Controls.MPGroupBox();
this.cbAllowNormal = new MediaPortal.UserInterface.Controls.MPCheckBox();
this.cbAllowZoom149 = new MediaPortal.UserInterface.Controls.MPCheckBox();
this.cbAllowOriginal = new MediaPortal.UserInterface.Controls.MPCheckBox();
this.cbAllowZoom = new MediaPortal.UserInterface.Controls.MPCheckBox();
this.cbAllowLetterbox = new MediaPortal.UserInterface.Controls.MPCheckBox();
this.cbAllowStretch = new MediaPortal.UserInterface.Controls.MPCheckBox();
this.cbAllowPanScan = new MediaPortal.UserInterface.Controls.MPCheckBox();
etc...

 

[ziphnor]

You must be doing something wrong. I checked out a fresh SVN copy, applied my batch, executed 'Build Release.bat" and ran xbmc/bin/Release/Configuration.exe and the allowed zoom modes where there.

 

[cpp2005]

Yes I did it as you said and I see these members in Television.cs, but I don't see the controls in design mode.
You didn't add this code directly, you used designer which added it (between other things) to InitializeComponents, right? I mean something need to be done to synchronize between designer view and C# code, I think those are resx files. May be I'm wrong and it's something on my computer, let's see what other people say.

 

[cpp2005]

Ok I did some tests and you are right, designer should synchronize automatically, so I did something wrong, sorry!

 

[ziphnor]

Ok I did some tests and you are right, designer should synchronize automatically, so I did something wrong, sorry!

You probably want to do a complete rebuild, the designer is a bit weird at times.

 

[ziphnor]

Hmm, still hasnt entered SVN..

If it hasnt made it to SVN yet because there is something wrong with it, could someone maybe fill me in on the problem so i can solve it?

 

[chrholm]

It would be nice to have this code added to SVN. Its a feature that have been requested numerous times, and now that somebody took the time to do it, please add it into SVN.

 

[cpp2005]

I did a rebuild and it's working perfectly, thanks ziphnor!

 

[diehard2]

If I had to guess, the developers probably allow people who are familiar with the code to add it. I wrote a patch for the firefly remote and it was added by mpod. I would think that frodo would monitor tv patches, and he is busy these days. I have a patch that I too would like added.