home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
Development
General Development (no feature request here!)
[Patch]Fix & improve vobsub-haali cooperation
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="peterk2007" data-source="post: 196403" data-attributes="member: 49171"><p>Hi everyone,</p><p></p><p>I've found out, that if Haali splitter installed with avi support, then vobsub autoload feature don't work on avi files with external subtitles (srt, sub, etc.). No matter how you set up vobsub, enable or disable haali's vobsub</p><p>autoload feature, it just doesn't work. Adding vobsub in mediaportal as postprocessing filter also does not solve the problem, because vobsub won't be included in the graph on rendering.</p><p></p><p>Since Haali's splitter otherwise works really great for avi-s too (for example handling avi files with multiple audio streams, etc) this haali bug (i guess) can be quite annoying.</p><p></p><p>So I made this pach to fix this issue in mediaportal. It does the following:</p><p></p><p>1. Looks for vobsub filter after the graph has been rendered.</p><p>2. If vobsub is there - either the autoloading or the "normal" version - then checks if it is properly connected. Checks for both the video and subtitle pins.</p><p>3. If the video pins are not connected, then inserts vobsub right before the vmr9 renderer.</p><p>4. If the subtitle input pin is not connected, then looks for haali splitter, and if it is there, then connects haali's subtitle output pin (if any) to vobsub.</p><p>5. Finally makes vobsub to refresh available subtitle streams (reloading available external subtitle info).</p><p></p><p>So with this patch, basically and generally you will be able to fix "vobsub not loading issues". Simply add vobsub as postprocessing filter, and then vobsub will always load and connect properly into the graph providing subtitles whenever possible. (If you added vobsub as postprocessing filter, you can disable autoloading in vobsub config, and also in haali config.) </p><p></p><p>This patch does not affect vobsub autoloading functionality. If vobsub autoloaded and connected properly, the patch does not touch it.</p><p></p><p>Affected files: VideoPlayerVMR9.cs, VMR9.cs</p><p></p><p>I used the latest SVN files (rev 16346) </p><p></p><p>I have submitted the patch to the tracker: <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=1819497&group_id=107397&atid=647927" target="_blank">Here</a></p><p></p><p>Cheers.</p></blockquote><p></p>
[QUOTE="peterk2007, post: 196403, member: 49171"] Hi everyone, I've found out, that if Haali splitter installed with avi support, then vobsub autoload feature don't work on avi files with external subtitles (srt, sub, etc.). No matter how you set up vobsub, enable or disable haali's vobsub autoload feature, it just doesn't work. Adding vobsub in mediaportal as postprocessing filter also does not solve the problem, because vobsub won't be included in the graph on rendering. Since Haali's splitter otherwise works really great for avi-s too (for example handling avi files with multiple audio streams, etc) this haali bug (i guess) can be quite annoying. So I made this pach to fix this issue in mediaportal. It does the following: 1. Looks for vobsub filter after the graph has been rendered. 2. If vobsub is there - either the autoloading or the "normal" version - then checks if it is properly connected. Checks for both the video and subtitle pins. 3. If the video pins are not connected, then inserts vobsub right before the vmr9 renderer. 4. If the subtitle input pin is not connected, then looks for haali splitter, and if it is there, then connects haali's subtitle output pin (if any) to vobsub. 5. Finally makes vobsub to refresh available subtitle streams (reloading available external subtitle info). So with this patch, basically and generally you will be able to fix "vobsub not loading issues". Simply add vobsub as postprocessing filter, and then vobsub will always load and connect properly into the graph providing subtitles whenever possible. (If you added vobsub as postprocessing filter, you can disable autoloading in vobsub config, and also in haali config.) This patch does not affect vobsub autoloading functionality. If vobsub autoloaded and connected properly, the patch does not touch it. Affected files: VideoPlayerVMR9.cs, VMR9.cs I used the latest SVN files (rev 16346) I have submitted the patch to the tracker: [URL="http://sourceforge.net/tracker/index.php?func=detail&aid=1819497&group_id=107397&atid=647927"]Here[/URL] Cheers. [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
Development
General Development (no feature request here!)
[Patch]Fix & improve vobsub-haali cooperation
Contact us
RSS
Top
Bottom