[Approved] - Patch for MPEI (min and max versions are backwards for TVServer dependency)

Discussion in 'Submit: code patches (MediaPortal/TV-Server/etc.)' started by cwchapma, April 26, 2013.

  1. cwchapma

    cwchapma Portal Pro

    Joined:
    October 15, 2006
    Messages:
    56
    Likes Received:
    17
    Ratings:
    +22 / 0
    Home Country:
    Canada Canada
    Show System Specs
    I've submitted a pull request that fixes the min and max version comparisons for a TVServer dependency. Is there anything special I need to do to have someone on the team consider it?



    Thanks,
    Clint
     
    • Like Like x 1
  2. Google AdSense Guest Advertisement



    to hide all adverts.
  3. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
    Thanks!
    @Developers :)
     
  4. seco
    • Team MediaPortal

    seco Development Group

    Joined:
    August 7, 2007
    Messages:
    1,579
    Likes Received:
    897
    Gender:
    Male
    Ratings:
    +1,234 / 4
    Home Country:
    Finland Finland
    Show System Specs
    I just had a quick look, there seems to be a lot of changes and the code is I guess something that is used elsewhere too.

    Maybe @offbyone knows this area?

    Also this kind of code is something we could really have Unit Tests for (and should have).
     
    Last edited: April 26, 2013
    • Like Like x 1
  5. offbyone
    • Team MediaPortal

    offbyone Development Group

    Joined:
    April 26, 2008
    Messages:
    3,981
    Likes Received:
    2,704
    Gender:
    Male
    Location:
    Stuttgart
    Ratings:
    +3,303 / 3
    Home Country:
    Germany Germany
    Show System Specs
    I've seen your pull request, but need some time to look at it. Maybe will get to it on the weekend.
     
    • Like Like x 1
  6. cwchapma

    cwchapma Portal Pro

    Joined:
    October 15, 2006
    Messages:
    56
    Likes Received:
    17
    Ratings:
    +22 / 0
    Home Country:
    Canada Canada
    Show System Specs
    Still hoping this will be looked at and not forgotten :)
     
  7. offbyone
    • Team MediaPortal

    offbyone Development Group

    Joined:
    April 26, 2008
    Messages:
    3,981
    Likes Received:
    2,704
    Gender:
    Male
    Location:
    Stuttgart
    Ratings:
    +3,303 / 3
    Home Country:
    Germany Germany
    Show System Specs
    Reviewed, and good to go in from my side.

    The "many" changes for a small fix are there because cwchapma actually implemened it cleaner than it currently was.

    The merge window for MP 1.4 is closed, I'll check back with the team when (now or next version) we can add this.
    Thanks!

    Mantis issue : http://mantis.team-mediaportal.com/view.php?id=4437
     
    Last edited: May 11, 2013
    • Like Like x 2
    • Agree Agree x 1
  8. cwchapma

    cwchapma Portal Pro

    Joined:
    October 15, 2006
    Messages:
    56
    Likes Received:
    17
    Ratings:
    +22 / 0
    Home Country:
    Canada Canada
    Show System Specs
  9. offbyone
    • Team MediaPortal

    offbyone Development Group

    Joined:
    April 26, 2008
    Messages:
    3,981
    Likes Received:
    2,704
    Gender:
    Male
    Location:
    Stuttgart
    Ratings:
    +3,303 / 3
    Home Country:
    Germany Germany
    Show System Specs
    Merged to master. Thanks for submitting!
     
    • Like Like x 1
  10. Holzi
    • Team MediaPortal

    Holzi Super Moderator

    Joined:
    April 21, 2010
    Messages:
    7,928
    Likes Received:
    1,591
    Gender:
    Male
    Location:
    Ba-Wü
    Ratings:
    +2,228 / 8
    Home Country:
    Germany Germany
    Show System Specs
Loading...

Users Viewing Thread (Users: 0, Guests: 0)

  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Dismiss Notice
  • About The Project

    The vision of the MediaPortal project is to create a free open source media centre application, which supports all advanced media centre functions, and is accessible to all Windows users.

    In reaching this goal we are working every day to make sure our software is one of the best.

             

  • Support MediaPortal!

    The team works very hard to make sure the community is running the best HTPC-software. We give away MediaPortal for free but hosting and software is not for us.

    Care to support our work with a few bucks? We'd really appreciate it!