[Approved] Patch to allow skins to open plugins with a parameter *Updated for 1.1* (1 Viewer)
- Thread starter DieBagger
- Start date
United States of America
Can you provide an updated version of the patch for the current SVN? There were some changes related to the ActiveWindow call in GUIButtonControl.cs since 1.1.0.
Once provided I quickly retest this one and commit it to SVN right away.
0003061: Patch to allow skins to open plugins with a parameter - MediaPortal Bugtracker
Once provided I quickly retest this one and commit it to SVN right away.
0003061: Patch to allow skins to open plugins with a parameter - MediaPortal Bugtracker
- Moderator
- #15
AW: Patch to allow skins to open plugins with a parameter *Updated for 1.1*
Hi Scythe42 - please no hurry! We were just discussing in another thread that we don´t like SVN commits without team approval. So please no more commits until the team voted on it.
EDIT: This applies also to Mantis 3060! Please do not commit.
Hi Scythe42 - please no hurry! We were just discussing in another thread that we don´t like SVN commits without team approval. So please no more commits until the team voted on it.
EDIT: This applies also to Mantis 3060! Please do not commit.
- Moderator
- #16
Re: AW: Patch to allow skins to open plugins with a parameter *Updated for 1.1*
What are you talking about? The whole purpose of this thread was to discuss the patch and it has gotten an overwhelming amount of approval from both plugin developers and MediaPortal team members. If you have any specific objections fine, lets talk about them, but this has already been reviewed and given favorable reviews by half a dozen people. The patch has been posted for 10 months, lets get this integrated.
What are you talking about? The whole purpose of this thread was to discuss the patch and it has gotten an overwhelming amount of approval from both plugin developers and MediaPortal team members. If you have any specific objections fine, lets talk about them, but this has already been reviewed and given favorable reviews by half a dozen people. The patch has been posted for 10 months, lets get this integrated.
- Moderator
- #17
AW: Patch to allow skins to open plugins with a parameter *Updated for 1.1*
I just wanted that this patch does not go in SVN before the other problem has been solved. I totally agree with this patch and would like to see it in next version
I just wanted that this patch does not go in SVN before the other problem has been solved. I totally agree with this patch and would like to see it in next version
- Thread starter
- #18
Re: AW: Patch to allow skins to open plugins with a parameter *Updated for 1.1*
Which problems are you referring to? I've made the patch compatible to the current svn...
3rd time's the charm
View attachment AllowSkinToOpenPluginWithParameter_r26458_2010-10-02.patch
I just wanted that this patch does not go in SVN before the other problem has been solved. I totally agree with this patch and would like to see it in next version
Which problems are you referring to? I've made the patch compatible to the current svn...
3rd time's the charm
View attachment AllowSkinToOpenPluginWithParameter_r26458_2010-10-02.patch
- Moderator
- #19
AW: Patch to allow skins to open plugins with a parameter *Updated for 1.1*
I was referring to another problem which has nothing to do with this patch.
I was referring to another problem which has nothing to do with this patch
.
Tested again, no issues on my box. Comitted tp SVN (26461)
On a side note. We have a versioning system. One bug introduced with one patch doesn't make other commits impossible. Just work on an older revision and later apply the changes to the trunk. This is especially true when the change are affecting different parts.
If anyone has problems with this, feel free to revert and take over testing pending community patches for MP1.
On a side note. We have a versioning system. One bug introduced with one patch doesn't make other commits impossible. Just work on an older revision and later apply the changes to the trunk. This is especially true when the change are affecting different parts.
If anyone has problems with this, feel free to revert and take over testing pending community patches for MP1.