[Approved] Patch to enhance TV notification (1 Viewer)

[SilentException]

splatterpop, did you follow any of my advices?

We just had discussion and having timeout in DialogYesNo or subclassing this dialog into TimedDialogYesNo in MediaPortal.Dialogs makes more sense. It's the calling of the dialog that doesn't work for you and that's why you should try what I have written.

 

[splatterpop]

Hi everyone, thanks for all the input. Here's the patch.

+ patched YesNo dialog with added timeout
+ patched TvNotifyManager

It works as expected, but unfortunately I could not test if tv and radio is activated correctly (problem with version of tv server).

Kind regards,
splatterpop

 

[SilentException]

Thanks for contributing!

I currently reworked TV notification part a bit but I will rework your patch too and apply it together when we (team) agree on this

 

[disaster123]

AW: Patch to enhance TV notification

any news? Or is it done with 27219?

 

[romuz]

Nope SilentException`s version of that patch is under internal testing now.

 

[SilentException]

Somehow modified and bit extended version of a patch was added in SVN r27245.

Thanks for contributing, original idea was still kept

 

[D3ltoroxp]

AW: Re: Patch to enhance TV notification

Hi everyone, thanks for all the input. Here's the patch.

+ patched YesNo dialog with added timeout
+ patched TvNotifyManager

It works as expected, but unfortunately I could not test if tv and radio is activated correctly (problem with version of tv server).

tvnotifydlg20101223.patch

Kind regards,
splatterpop

Is this the latest patch? And it works fine?

 

[riksmith]

Re: AW: Re: Patch to enhance TV notification

Hi everyone, thanks for all the input. Here's the patch.

+ patched YesNo dialog with added timeout
+ patched TvNotifyManager

It works as expected, but unfortunately I could not test if tv and radio is activated correctly (problem with version of tv server).

tvnotifydlg20101223.patch

Kind regards,
splatterpop

Is this the latest patch? And it works fine?

No that is not the latest version. The latest version of the code is in SVN.

 

[D3ltoroxp]

AW: Re: AW: Re: Patch to enhance TV notification

Hi everyone, thanks for all the input. Here's the patch.

+ patched YesNo dialog with added timeout
+ patched TvNotifyManager

It works as expected, but unfortunately I could not test if tv and radio is activated correctly (problem with version of tv server).

tvnotifydlg20101223.patch

Kind regards,
splatterpop

Is this the latest patch? And it works fine?

No that is not the latest version. The latest version of the code is in SVN.

Sorry, what do you mean exactly is in SVN?

The code (not the same as the patch you refer to!) has been commited in our SVN (our source control repository)

SorryI still do not understand completely. Or maybe. The code of this patch has been integrated into the current SVN of MediaPortal? Did you this ? If so should the changes be automatically provided by this patch in a newer version of MediaPortal properly ?

 

[DieBagger]

Re: AW: Re: AW: Re: Patch to enhance TV notification

Sorry, what do you mean exactly is in SVN?

The code (not the same as the patch you refer to!) has been commited in our SVN (our source control repository)

SorryI still do not understand completely. Or maybe. The code of this patch has been integrated into the current SVN of MediaPortal? Did you this ? If so should the changes be automatically provided by this patch in a newer version of MediaPortal properly ?

It means that the functionality that this patch provided has been implemented in the MediaPortal source (-> current svn) but not the patch itself since SilentException made some changes to the original patch of the author.