"public MusicTag GetStreamTags()" is missing under class "MediaPortal.Player.BassAudioEngine" (1 Viewer)

[pünktchen]

I've tried to get get RadioTime compatible with MP 1.4 pre, but because of "GetStreamTags()" is missing in "BassAudioEngine" a rebuild gets failed. Where is it gone or what to do now?

Also "using MP.Externals.BASS" throws an error. I've used "using MediaPortal.MusicPlayer.BASS", is this right?

Maybe @hwahrmann knows what i have to do?!

This is the code from RadioTime plugin:

void Player_InternetStreamSongChanged(object sender)
	{
	  if(!g_Player.Playing)
		return;
	  BassAudioEngine engine = sender as BassAudioEngine;
	  MusicTag tag = engine.GetStreamTags();
	  var dlg1 = (GUIDialogNotify)GUIWindowManager.GetWindow((int)Window.WINDOW_DIALOG_NOTIFY);
	  if (dlg1 == null) return;
	  dlg1.Reset();
	  dlg1.SetHeading("");
	  dlg1.SetText(tag.Artist + "-" + tag.Title);
	  dlg1.Reset();
	  dlg1.TimeOut = 3;
	  dlg1.DoModal(GetID);
	}

Edit: Found the git commit where the method was removed from @hwahrmann:
[url]https://github.com/MediaPortal/MediaPortal-1/commit/3e04b2e96c1e5e75d1a41eab3bdb1b246fda0a19[/Url]

 

[Holzi]

Maybe @seco can help too because he uses BASS in his Rockstar plugin.
Thanks!

 

[yoavain]

Just received a PM from hwahrmann. He said he didn't know the GetStreamTags() is being used by anyone, and said he will bring the method back into the code. Unfortunately, this means MyLyrics will not be compatible for 1.4 pre.

 

[pünktchen]

Oh MyLyrics also uses this method? I'm so sorry for you. In RadioTime i've just commented out the relevant code and no problems so far
I'm waiting for error reports by users...
Maybe hwahrmann can provide a patched core.dll for your extension installer?
(I will also try it, but have never build such a big project before.)

 

[hwahrmann]

Code is back in Bass Player.
It is in git in branch: origin/BUG-4451-GetStreamTags_removed_as_part_of_BASS_Rework_by_accident

will be merged to master as sson as it is tested.

 

[yoavain]

Oh MyLyrics also uses this method? I'm so sorry for you. In RadioTime i've just commented out the relevant code and no problems so far
I'm waiting for error reports by users...
Maybe hwahrmann can provide a patched core.dll for your extension installer?
(I will also try it, but have never build such a big project before.)

The problem is not compiling the MP. I can do that myself. But I'm not going to publish it anywhere.
I'll see if I can also comment out the code until there's another official release with the code back in. This is only so that people will be able to use MyLyrics with 1.4 pre. However, if it's going to affect critical functionality, I will not publish it.