home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
Area 51 - Testing Area
Ready for Testing - PowerScheduler++ integrated in MediaPortal 1.4
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="chefkoch" data-source="post: 1016421" data-attributes="member: 10438"><p>I have not hours of time to explain it over and over again so I rather link to an quote the appropriate parts in documentation <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink ;)" loading="lazy" data-shortname=";)" /></p><p> </p><p> </p><p></p><p>source: <a href="http://wiki.team-mediaportal.com/9_Team_Mediaportal/3_Online_Facilities/JIRA/2_Using_FishEye_and_Crucible/Creating_CodeReviews#Creating_code_reviews_from_within_JIRA" target="_blank">http://wiki.team-mediaportal.com/9_Team_Mediaportal/3_Online_Facilities/JIRA/2_Using_FishEye_and_Crucible/Creating_CodeReviews#Creating_code_reviews_from_within_JIRA</a></p><p> </p><p> </p><p></p><p>source:</p><p><a href="http://wiki.team-mediaportal.com/9_Team_Mediaportal/3_Online_Facilities/JIRA/2_Using_FishEye_and_Crucible/Creating_CodeReviews#Creating_code_reviews_if_changesets_are_not_linked" target="_blank">http://wiki.team-mediaportal.com/9_Team_Mediaportal/3_Online_Facilities/JIRA/2_Using_FishEye_and_Crucible/Creating_CodeReviews#Creating_code_reviews_if_changesets_are_not_linked</a></p><p> </p><p>There I also added the following</p><p></p><p> </p><p> </p><p></p><p>It's is also possible to use smart commits, but I don't want to overload our devs with "too much information" and alternatives to choose from, which would requires understanding each of them before being able to make a choice.</p><p> </p><p></p><p>Yep, that's makes it easier for the moment you initially create the review, but adding new commits to existing reviews has to be done "manually". The button in JIRA is only for creating a review, iirc.</p><p> </p><p></p><p>Depends on the size of the branch. The CableCard one was a bigger branch and took a quite a bit time to do properly, but a review for 15 commits should be done easily in 5 to 10 minutes once you are used to it. And in case the JIRA issue keys are included in the commit message it's once click in JIRA so less than once minute.</p><p> </p><p> </p><p> </p><p>I want to make it clear again:</p><ul> <li data-xf-list-type="ul">I am <strong>not</strong> <strong>responsible</strong> for having code reviews as a requirement for the merge. That was a team decision that has been made after weeks and months of discussion back and forth.</li> <li data-xf-list-type="ul">It was possible to do these reviews also already since years by using github, forum and IRC like we did it for MP2.</li> <li data-xf-list-type="ul">There were always requests for a tool for doing code reviews, keeping track of the status and things like comments and who approved this code and when.</li> </ul><p>BUT</p><ul> <li data-xf-list-type="ul">If Crucible is being used and things are not clear how to do it, <strong>I am happy to explain</strong> the possibilities <strong>and document</strong> them.</li> <li data-xf-list-type="ul">If these things are either not read or the amount of time or the effort to try to understand them are too much, then I can not do anything about it. I can not re-code fisheye and Crucible to be more "developer friendly" or I can not change the developing workflow and let a MP1 lead developer magically appear who does these reviews without Crucible.</li> </ul><p></p><p> </p><p>Nevertheless, maybe the smart commits might help those devs who don't want to use the Crucible GUI to create reviews but remember to add some additional commands to each commit message for each commit. This needs to be tested first and documented, but might need take some time.</p></blockquote><p></p>
[QUOTE="chefkoch, post: 1016421, member: 10438"] I have not hours of time to explain it over and over again so I rather link to an quote the appropriate parts in documentation ;) source: [url]http://wiki.team-mediaportal.com/9_Team_Mediaportal/3_Online_Facilities/JIRA/2_Using_FishEye_and_Crucible/Creating_CodeReviews#Creating_code_reviews_from_within_JIRA[/url] source: [url]http://wiki.team-mediaportal.com/9_Team_Mediaportal/3_Online_Facilities/JIRA/2_Using_FishEye_and_Crucible/Creating_CodeReviews#Creating_code_reviews_if_changesets_are_not_linked[/url] There I also added the following It's is also possible to use smart commits, but I don't want to overload our devs with "too much information" and alternatives to choose from, which would requires understanding each of them before being able to make a choice. Yep, that's makes it easier for the moment you initially create the review, but adding new commits to existing reviews has to be done "manually". The button in JIRA is only for creating a review, iirc. Depends on the size of the branch. The CableCard one was a bigger branch and took a quite a bit time to do properly, but a review for 15 commits should be done easily in 5 to 10 minutes once you are used to it. And in case the JIRA issue keys are included in the commit message it's once click in JIRA so less than once minute. I want to make it clear again: [LIST] [*]I am [B]not[/B] [B]responsible[/B] for having code reviews as a requirement for the merge. That was a team decision that has been made after weeks and months of discussion back and forth. [*]It was possible to do these reviews also already since years by using github, forum and IRC like we did it for MP2. [*]There were always requests for a tool for doing code reviews, keeping track of the status and things like comments and who approved this code and when. [/LIST] BUT [LIST] [*]If Crucible is being used and things are not clear how to do it, [B]I am happy to explain[/B] the possibilities [B]and document[/B] them. [*]If these things are either not read or the amount of time or the effort to try to understand them are too much, then I can not do anything about it. I can not re-code fisheye and Crucible to be more "developer friendly" or I can not change the developing workflow and let a MP1 lead developer magically appear who does these reviews without Crucible. [/LIST] Nevertheless, maybe the smart commits might help those devs who don't want to use the Crucible GUI to create reviews but remember to add some additional commands to each commit message for each commit. This needs to be tested first and documented, but might need take some time. [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
Area 51 - Testing Area
Ready for Testing - PowerScheduler++ integrated in MediaPortal 1.4
Contact us
RSS
Top
Bottom