[Approved] Refactor of InputDevices to Map actions without triggering them (1 Viewer)

[Jason Pyke]

As part of OnlineVideos there is the option of launching an external executable to play a video and this application needs to respond to different remote actions. The patch adds the ability to map a WndProc message or a KeyPress event to the Input handlers and return an Action without actually triggering the Action.

By reworking this it means we can keep the external executable free of dependencies on MediaPortal 1 and can still handle input devices and actions.

 

[offbyone]

Branch:
https://github.com/MediaPortal/MediaPortal-1/tree/MP1-4631-FEAT-Refactor_InputDevices

JIRA:
https://issues.team-mediaportal.com/browse/MP1-4631

Review:
https://issues.team-mediaportal.com/fisheye/cru/MP1CR-639

 

[offbyone]

Hi, @Sebastiii - thanks for reviewing, can you create a bot build for this branch and link it here for testers?

 

[Sebastiii]

Will post the link ASAP

 

[Sebastiii]

Installer added to JIRA and here

 

[Stéphane Lenclud]

I don't fully understand what that patch does.
I'm not quite sure what you do with your Action once you get it?
Are you somehow sending it to your external program?
Is it a case of MP getting the input and that external program responding on it?

I wanted to start working on gamepad support so I was considering building on top of that patch to avoid merge conflict later on.

 

[Stéphane Lenclud]

Ok so I went ahead and implemented gamepad support on top of this branch.
https://forum.team-mediaportal.com/threads/mp1-4635-gamepad-support.130137/
Do let me know whenever this goes on master so that I can rebase my changes and get them on master too.

 

[Jason Pyke]

You're correct about the patch. Basically, it allows me to pass the wndproc and keypresses from the external application back to MP to be translated to actions. These actions then get passed on to the exe. Without this patch the actions would also be executed within MP, causing undesirable side effects.

 

[Stéphane Lenclud]

Sounds rather twisted but why not, if it works Thanks for the clarifications.