regeszter's custom MP (3 Viewers)

[regeszter]

HI and thanks for all your work. Is your current branch anywhere here? https://github.com/regeszter/MediaPortal-1/

It is not current.

 

[disaster123]

Are you willing to push one? It would be great to have the possibililty to cherry-pick some of your features into an own / custom branch.

 

[regeszter]

Are you willing to push one? It would be great to have the possibililty to cherry-pick some of your features into an own / custom branch.

It is only my TVE3 branch. Do you want to see my MP1 related changes (MySQL related)?

https://github.com/regeszter/MediaPortal-1/commits/my_TVE3_working

 

[Sebastiii]

I notice an error on upgrade database for mysql

This is the corrected one, before, it try to alter mptvdb database but if we are on another database name, it failed to start setuptv

USE %TvLibrary%;

ALTER TABLE channelgroup ADD COLUMN pinCode VARCHAR(5) NULL  AFTER sortOrder ;

UPDATE version SET versionNumber=62 WHERE idVersion=1;

 

[disaster123]

Are you willing to push one? It would be great to have the possibililty to cherry-pick some of your features into an own / custom branch.

It is only my TVE3 branch. Do you want to see my MP1 related changes (MySQL related)?

https://github.com/regeszter/MediaPortal-1/commits/my_TVE3_working

Thanks! Any Chance to get clean / separate commits for the features? This would make it easier to test and use single features. May be also mp devs would like to pick some.

f.e. https://github.com/regeszter/MediaPortal-1/commit/3dc20d00fd9c0a04a7d2b2445eb4f4c217b57d62

Thank you for sharing your work.

 

[regeszter]

Any Chance to get clean / separate commits for the features?

It would be a hard work. I joined to the team after code freeze (two years ago) of TVE3 so all code was written for own.

 

[Sebastiii]

I have merge your change on my own build and like this i can test more
On my side it's the PIN for channel that i'm interested

I just add some code to be able to hide / unhide recorded items. When i have look the code, i didn't find if it's possible. I can put my change here and you can port to your build too ?

This need language + skin change to get the option available from hidden menu (right or left (skin dependent).

I do it like this :

If the the pin-code is ok, then we get all recorded disallowed available.

If we want to hide them again, we just need to go to hidden menu and select 'Unhide/hide .....' and we get the question to hide them and this time no need to hit the pin-code (because we want to hide them) but if we want to show them again, we need to put the pin-code.

And Voila, the recorded disallowed items are hidden

What do you think ?

The only thingy that i'm not really good, it's that we forget to hide them, recorded disallowed will be present, i didn't find a way to only re-enter pin-code when we go outside of tvrecorded.
At first it was ok to put some bool in OnPageLoad() but OnPageLoad() is always reloaded after playing a recorded TV.

 

[regeszter]

I just add some code to be able to hide / unhide recorded items.

Why if it exists? You can see the PIN protected items if you change the current channel group to that group where the channel exists.

The only thingy that i'm not really good, it's that we forget to hide them

It is fixed on my side. You will always enter to a free group after enter to Tv Pugin.

 

[Sebastiii]

I'm not sure we talk about the same thing (or i didn't follow you lol)
I just find a way to reset back to recorded items hidden only when going outside of tvrecorded window So if we want them again, we need to put pin-code, so now i'm not sure if we need to keep the unhide/hide feature.

So if i summarize :

1- Enter in TVRecorded
2- Items hidden are not available until going to context menu and select to show them with pin-code
3- if we play something, all items are present
4- if we go outside TVRecorded window, items are hidden and if we want them again, we need to go to context menu and pin-code.

I will push my change and you can compare

 

[regeszter]

2- Items hidden are not available until going to context menu and select to show them with pin-code

Why do you want to add hide/unhide function to context menu?

Which group of PIN code will you enter? You can create more than one PIN protected groups. One for horror one for xxx.