[Approved] Remove an active recording that is playing (1 Viewer)

[riksmith]

It is not possible to delete a recording from the MP recordings screen that is:
Currently recording and currently being played.

When you try this the following happens:

1. Recording stops.
2. It takes a few seconds then a message pops-up that it was not possible to delete this recording.
3. The recording keeps playing.

With this patch it should works as i expected:

1. Recording stops.
2. Playback stops
3. The recording is removed.

I do not know how this behaves in multi seat, i only have single seat.

 

[gibman]

thanks.

Indeed there is an issue. Not a very critical one though.

Your fix doesn't work for me on multiseat.
"unable to delete recording".

I'm also running the latest fix you did for disposing in tsreader class.
If I am not plyaing back the recording then no problems.
Or if I stop playback of the live recording before deleting it, then no problem either.

added new mantis-
0002674: Unable to remove an active recording that is also playing - MediaPortal Bugtracker

/gibman

 

[riksmith]

What's the difference in your scenario? Are playing on client 1 and removing on client 2? Or is it all at 1 client?

I can imagine the scenario's with two clients does not work (and should).

EDIT: I just found out the fix for disposing in tsreader class is not committed correctly, it does not work that way. So it could be that that is the problem here!

 

[gibman]

Hi!

Problems occur when you have a multiseat client using SMB mode.
Pretty often I am denied access to the file, so file deletion fails.

Im pretty sure it doesnt happen when using RTSP mode, as the client doesnt touch the file here.

I haven't been able to solve the file lock yet.

Can u compile a new tsreader.ax ?

I'm also on IRC btw

/gibman

What's the difference in your scenario? Are playing on client 1 and removing on client 2? Or is it all at 1 client?

I can imagine the scenario's with two clients does not work (and should).

EDIT: I just found out the fix for disposing in tsreader class is not committed correctly, it does not work that way. So it could be that that is the problem here!

 

[riksmith]

Why do you need an tsreader.ax? If you wan't my changes: They are in the MP dll's, not in TSReader. Can you compile that yourself?

Also: i don't have irc.. only MSN.

 

[gibman]

The problem has been solved now and is in SVN-

/gibman

 

[Spragleknas]

Why do you need an tsreader.ax? If you wan't my changes: They are in the MP dll's, not in TSReader. Can you compile that yourself?

Also: i don't have irc.. only MSN.

MEDIAPORTAL - free media center - WebIRC

 

[Seidelin]

I set the status of this thread to approved since a version of this fix is already in SVN since a few days.