[Pending] Remove unneeded video-windows from code (1 Viewer)

pilehave

Community Skin Designer
  • Premium Supporter
  • April 2, 2008
    2,566
    521
    Hornslet
    Denmark Denmark
    • Thread starter
    • Moderator
    • #1
    Hi

    In The TVPlugin we have TVGuide.cs (mytvguide.xml), that contains some (leftover?) skin controls:

    [SkinControl(98)] protected GUIImage videoBackground;
    [SkinControl(99)] protected GUIVideoControl videoWindow;

    These controls are not used anywhere in the plugin. In fact, the only place where there is a GUIVideoControl is in TVHome.cs, but this has another ID and is not related to the one at hand.

    Why would I remove it?
    Simply because with every skin MP complains about the missing controls. Any skin I know uses the overlay-windows to display video in a corner (if needed).

    In addition to this, MediaPortal itself also has this leftover control two places; in GUIHomeBaseWindow.cs (myHome.xml) and in GUIBasicHome.cs (BasicHome.xml).

    Here MP even seems to initiate the controls on page load:

    GUIHomeBaseWindow.cs:
    Code:
    	protected override void OnPageLoad()
    	{
    	  base.OnPageLoad();
    	  //set video window position
    	  if (videoWindow != null)
    	  {
    		videoWindow.OnInit();
    	  }
    	}
    and GUIBasicHome.cs:
    Code:
    	  //set video window position
    	  if (_videoWindow != null)
    	  {
    		GUIGraphicsContext.VideoWindow = new Rectangle(_videoWindow.XPosition, _videoWindow.YPosition,
    													  _videoWindow.Width, _videoWindow.Height);
    	  }
    Why would it do that? Isn't the skin supposed to use the overlay windows to show video?

    As far as I can tell, removing these controls and the code with them gives no sideeffects when building and running MediaPortal. I'll be happy to supply patches, but want to get your take on why the code is even there.

    :D
     
    Last edited by a moderator:

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    OP Similar threads Forum Replies Date
    HTPCSourcer [Evaluate] Remove obsolete menu entries from "MP2 TV Configuration" MediaPortal 2 0
    R [solved] Moving pictures importer wont add files from a removable drive. Is there a work around ? Moving Pictures 8
    HTPCSourcer [Evaluate] MP2-Updates do not remove the GUID of previous installs MediaPortal 2 13
    stirlinghart [solved] Remove recording started & finished pop ups General 2
    D Remove "Old" client names from Service Monitor? General 5
    stirlinghart How to remove menu overlay General 11
    N [not reproducible] Online videos not working at all Submit: Bug Reports 1
    R Bug: Video Folders disappear General Support 11
    Stephen O'Kane [SOLVED] TV Stream stuttering - both Video and Audio Watch / Listen Media 14
    B some music videos stutter Watch / Listen Media 0
    I 1.25.0 Videos in HEVC UHD 2160p don't play good watch/edit Videos 8
    CanadianEh MP TV server rebuild with Colossus 2 - Kodi clients receive PMT error when playing videos recoreded by Colossus 2 TV-Server 1
    Rob Hexenmeister Skinning Online Videos question OnlineVideos 2
    A [solved] How to Play All Videos in a List watch/edit Videos 3
    O 1.25.0 Codecs and Video Format for PlayStation 2 Codecs, External Players 0
    g0rsq Info box randomly popping up when watching TV or other video MediaPortal 2 Newcomers Forum 1
    I Video Playback Stuttering General Support 45
    B some videos jerky Television (MyTV frontend and TV-Server) 0
    B MP 2.2.3 Error playing videos from NAS Submit: Bug Reports 2
    T Kurze Tonaussetzter bei Videos und TV Allgemeines Supportforum 1
    mrmojo666 [Tv Server Plugin ]Direct Show Video Control Plugin 0.0.0.1 for Hauppauge PVR cards MediaPortal 1 Plugins 0
    ajs [Proposal] Video embedded cover MediaPortal 1 1
    G [solved] Black Screen on all videos after upgrading to either 1.23 or 1.24 from 1.22 General Support 4
    H random black screen live tv and videos (amended) General Support 0
    404 [solved] Live TV...video and audio freeze General Support 20
    Similar threads

























    Top Bottom