Reply to thread

Message

<blockquote data-quote="pilehave" data-source="post: 799882" data-attributes="member: 71550">Hi&nbsp;In The TVPlugin we have TVGuide.cs (mytvguide.xml), that contains some (leftover?) skin controls:&nbsp;[SkinControl(98)] protected GUIImage videoBackground;[SkinControl(99)] protected GUIVideoControl videoWindow;&nbsp;These controls are not used anywhere in the plugin. In fact, the only place where there is a GUIVideoControl is in TVHome.cs, but this has another ID and is not related to the one at hand.&nbsp;Why would I remove it?Simply because with every skin MP complains about the missing controls. Any skin I know uses the overlay-windows to display video in a corner (if needed).&nbsp;In addition to this, MediaPortal itself also has this leftover control two places; in GUIHomeBaseWindow.cs (myHome.xml) and in GUIBasicHome.cs (BasicHome.xml).&nbsp;Here MP even seems to initiate the controls on page load:&nbsp;GUIHomeBaseWindow.cs:[CODE]&nbsp; &nbsp; protected override void OnPageLoad()&nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; base.OnPageLoad();&nbsp; &nbsp; &nbsp; //set video window position&nbsp; &nbsp; &nbsp; if (videoWindow != null)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; videoWindow.OnInit();&nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; }[/CODE]&nbsp;and GUIBasicHome.cs:[CODE]&nbsp; &nbsp; &nbsp; //set video window position&nbsp; &nbsp; &nbsp; if (_videoWindow != null)&nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; GUIGraphicsContext.VideoWindow = new Rectangle(_videoWindow.XPosition, _videoWindow.YPosition,&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; _videoWindow.Width, _videoWindow.Height);&nbsp; &nbsp; &nbsp; }[/CODE]&nbsp;Why would it do that? Isn't the skin supposed to use the overlay windows to show video?&nbsp;As far as I can tell, removing these controls and the code with them gives no sideeffects when building and running MediaPortal. I'll be happy to supply patches, but want to get your take on why the code is even there.&nbsp;<img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite8" alt=":D" title="Big Grin&nbsp; &nbsp; :D" loading="lazy" data-shortname=":D" /></blockquote>

[QUOTE="pilehave, post: 799882, member: 71550"] Hi In The TVPlugin we have TVGuide.cs (mytvguide.xml), that contains some (leftover?) skin controls: [SkinControl(98)] protected GUIImage videoBackground; [SkinControl(99)] protected GUIVideoControl videoWindow; These controls are not used anywhere in the plugin. In fact, the only place where there is a GUIVideoControl is in TVHome.cs, but this has another ID and is not related to the one at hand. [B]Why would I remove it?[/B] Simply because with every skin MP complains about the missing controls. Any skin I know uses the overlay-windows to display video in a corner (if needed). In addition to this, MediaPortal itself also has this leftover control two places; in GUIHomeBaseWindow.cs (myHome.xml) and in GUIBasicHome.cs (BasicHome.xml). Here MP even seems to initiate the controls on page load: [B]GUIHomeBaseWindow.cs[/B]: [CODE] protected override void OnPageLoad() { base.OnPageLoad(); //set video window position if (videoWindow != null) { videoWindow.OnInit(); } } [/CODE] and [B]GUIBasicHome.cs[/B]: [CODE] //set video window position if (_videoWindow != null) { GUIGraphicsContext.VideoWindow = new Rectangle(_videoWindow.XPosition, _videoWindow.YPosition, _videoWindow.Width, _videoWindow.Height); } [/CODE] Why would it do that? Isn't the skin supposed to use the overlay windows to show video? As far as I can tell, removing these controls and the code with them gives no sideeffects when building and running MediaPortal. I'll be happy to supply patches, but want to get your take on why the code is even there. :D [/QUOTE]

Verification