Reply to thread

Message

<blockquote data-quote="MJGraf" data-source="post: 1028682" data-attributes="member: 17886">Thanks Morph,At least according to the specs, &quot;limit X&quot;, &quot;limit X offset y&quot;, as well as &quot;limit y,x&quot; should work in SQLite also together with joins. Extending the ISQLDatabase interface accordingly so that also DBs that do not support this is IMO a good idea.Just as a side note: I rebased to current dev branch last night and since then there is no more LIMIT 1 at the end of the queries issued to fetch the covers. As a comparisonThis is how such a query looked like based on the older EXP_wip branch I used until yesterday evening:[CODE][2013-09-21 19:26:24,808] [4423623] [39&nbsp; &nbsp; &nbsp;&nbsp; ] [DEBUG] - MediaLibrary: Search time 00:00:00.0051193 for query MediaItemQuery: NecessaryRequestedMIATypes: [493f2b3b-8025-4db1-80dc-c3cd39683c9f, 1fda5774-9ac5-4873-926c-e84e3c36a966], OptionalRequestedMIATypes: [], Filter: [AudioItem.Album EQ 16 Biggest Hits], SortInformation: [MediaPortal.Common.MediaManagement.MLQueries.SortInformation] LIMIT 1[/CODE]And this is how it looks like based on current dev:[CODE][2013-09-22 02:07:57,785] [87993&nbsp; ] [35&nbsp; &nbsp; &nbsp;&nbsp; ] [DEBUG] - MediaLibrary: Search time 00:00:00.0401839 for query MediaItemQuery: NecessaryRequestedMIATypes: [493f2b3b-8025-4db1-80dc-c3cd39683c9f, 1fda5774-9ac5-4873-926c-e84e3c36a966], OptionalRequestedMIATypes: [], Filter: [AudioItem.Album EQ 1], SortInformation: [][/CODE]As you can see, the &quot;LIMIT 1&quot; at the end is missing now. The code that logs this is unchanged as displayed above (just miq.ToString()).I don't know how this query is initiated - probably somewhere in a skin model from which I have no knowledge at all. Maybe you, Morpheus_xx can point me where to look at to make sure this is not a bug.Thanks, Michael</blockquote>

[QUOTE="MJGraf, post: 1028682, member: 17886"] Thanks Morph, At least according to the specs, "limit X", "limit X offset y", as well as "limit y,x" should work in SQLite also together with joins. Extending the ISQLDatabase interface accordingly so that also DBs that do not support this is IMO a good idea. Just as a side note: I rebased to current dev branch last night and since then there is no more LIMIT 1 at the end of the queries issued to fetch the covers. As a comparison This is how such a query looked like based on the older EXP_wip branch I used until yesterday evening: [CODE] [2013-09-21 19:26:24,808] [4423623] [39 ] [DEBUG] - MediaLibrary: Search time 00:00:00.0051193 for query MediaItemQuery: NecessaryRequestedMIATypes: [493f2b3b-8025-4db1-80dc-c3cd39683c9f, 1fda5774-9ac5-4873-926c-e84e3c36a966], OptionalRequestedMIATypes: [], Filter: [AudioItem.Album EQ 16 Biggest Hits], SortInformation: [MediaPortal.Common.MediaManagement.MLQueries.SortInformation] LIMIT 1 [/CODE] And this is how it looks like based on current dev: [CODE] [2013-09-22 02:07:57,785] [87993 ] [35 ] [DEBUG] - MediaLibrary: Search time 00:00:00.0401839 for query MediaItemQuery: NecessaryRequestedMIATypes: [493f2b3b-8025-4db1-80dc-c3cd39683c9f, 1fda5774-9ac5-4873-926c-e84e3c36a966], OptionalRequestedMIATypes: [], Filter: [AudioItem.Album EQ 1], SortInformation: [] [/CODE] As you can see, the "LIMIT 1" at the end is missing now. The code that logs this is unchanged as displayed above (just miq.ToString()). I don't know how this query is initiated - probably somewhere in a skin model from which I have no knowledge at all. Maybe you, Morpheus_xx can point me where to look at to make sure this is not a bug. Thanks, Michael [/QUOTE]

Verification