Reply to thread

Message

<blockquote data-quote="Sypher" data-source="post: 569375" data-attributes="member: 77144">Re: SubtitleDownloader 1.7I've sifted a bit (I'm not a C# coder) trough the sourcecode (the bierdopjesubtitles.zip you mentioned in your first post) and discovered that your implementation of the Bierdopje-api isn't very efficient.You request every episode for a specific show, and then you narrow it down to the one you want.Instead, you could (and I suggest you do that for certain reasons) try the &quot;GetAllSubsFor&quot; call.The show id parameter can both be the showid they use at the site or the TheTVDB ID.Please note that you should set the &quot;istvdbid&quot; to true if the ID given is the TheTVDB ID.So the call will be:GetAllSubsFor/73739/1/1/nl/true (the parameters: integer showid, integer season, integer episode, string language(nl/en), (optional: istvdbid true/false))If you want the subs for Lost S01E01.This way, you can do less calls, and the whole process should be working a bit faster and saves both server as client bandwidth. <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" /></blockquote>

[QUOTE="Sypher, post: 569375, member: 77144"] [b]Re: SubtitleDownloader 1.7[/b] I've sifted a bit (I'm not a C# coder) trough the sourcecode (the bierdopjesubtitles.zip you mentioned in your first post) and discovered that your implementation of the Bierdopje-api isn't very efficient. You request every episode for a specific show, and then you narrow it down to the one you want. Instead, you could (and I suggest you do that for certain reasons) try the "GetAllSubsFor" call. The show id parameter can both be the showid they use at the site or the TheTVDB ID. Please note that you should set the "istvdbid" to true if the ID given is the TheTVDB ID. So the call will be: GetAllSubsFor/73739/1/1/nl/true (the parameters: integer showid, integer season, integer episode, string language(nl/en), (optional: istvdbid true/false)) If you want the subs for Lost S01E01. This way, you can do less calls, and the whole process should be working a bit faster and saves both server as client bandwidth. :) [/QUOTE]

Verification