Reply to thread

Message

<blockquote data-quote="seco" data-source="post: 569380" data-attributes="member: 54595">Re: SubtitleDownloader 1.7Thanks for the input Sypher <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" />Bierdopje implementation was actually made by a forum member Powdor, many thanks for him for getting the Bierdopje support in the first place.Back then I reviewed the code for optimizations and had couple of ideas, but I ran into some other problems when trying to implement those. I'll check your suggestion and the code again to see if some improvements could be made (btw the code in bierdopjesubtitles.zip is not same as line-to-line that in SubtitleDownloader)EDIT: I'm not sure where you want me to use GetAllSubsFor ? It seems to be internal method that cannot be called from my code? I could have also used GetEpisodeById which is internal too in the SaveSubtitle() implementation..</blockquote>

[QUOTE="seco, post: 569380, member: 54595"] [b]Re: SubtitleDownloader 1.7[/b] Thanks for the input Sypher :) Bierdopje implementation was actually made by a forum member Powdor, many thanks for him for getting the Bierdopje support in the first place. Back then I reviewed the code for optimizations and had couple of ideas, but I ran into some other problems when trying to implement those. I'll check your suggestion and the code again to see if some improvements could be made (btw the code in bierdopjesubtitles.zip is not same as line-to-line that in SubtitleDownloader) EDIT: I'm not sure where you want me to use GetAllSubsFor ? It seems to be internal method that cannot be called from my code? I could have also used GetEpisodeById which is internal too in the SaveSubtitle() implementation.. [/QUOTE]

Verification