Reply to thread

Message

<blockquote data-quote="MrJul" data-source="post: 884768" data-attributes="member: 113510">Hello seco,&nbsp;I think there are legitimate cases where keeping the directory structure could be wanted. In fact, in the sous-titres.eu downloader I wrote, I had to perform some analysis of the structure. Some downloaded zips may contain multiple languages, one per sub directory. Thus, the files are filtered and only those needed are extracted, based on the desired subtitle language. To perform this operation, both file names and directory names are checked. Then, the resulting path is transformed into a more user-friendly file name without a directory structure, which is what is returned to SubtitleDownloader.&nbsp;This is actually why the sous-titres.eu downloader broke recently. I was using the SevenZip lib directly to have access to the structure for filtering, and as a bonus, only extract the needed files for performance. I now directly use SharpCompress instead. If I could have access to the needed structure without directly referencing the compression library, it could be great. That being said, I realize this case is very specific, and that such a change could easily break compatibility with other downloaders. Currently, I don't really mind using the SharpCompress library: I don't think you'll be changing it again soon, and even if you do, the fix should be quick and easy <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" /></blockquote>

[QUOTE="MrJul, post: 884768, member: 113510"] Hello seco, I think there are legitimate cases where keeping the directory structure could be wanted. In fact, in the sous-titres.eu downloader I wrote, I had to perform some analysis of the structure. Some downloaded zips may contain multiple languages, one per sub directory. Thus, the files are filtered and only those needed are extracted, based on the desired subtitle language. To perform this operation, both file names and directory names are checked. Then, the resulting path is transformed into a more user-friendly file name without a directory structure, which is what is returned to SubtitleDownloader. This is actually why the sous-titres.eu downloader broke recently. I was using the SevenZip lib directly to have access to the structure for filtering, and as a bonus, only extract the needed files for performance. I now directly use SharpCompress instead. If I could have access to the needed structure without directly referencing the compression library, it could be great. That being said, I realize this case is very specific, and that such a change could easily break compatibility with other downloaders. Currently, I don't really mind using the SharpCompress library: I don't think you'll be changing it again soon, and even if you do, the fix should be quick and easy :) [/QUOTE]

Verification