[Approved] Teletext subtitle page based on Service Information (1 Viewer)

[elliottmc]

Is this patch working perfectly now, or are there any issues?

Mark

 

[Sebastiii]

A branch was created

 

[Wbunaarf]

A branch was created

This branch was created from the pull request rather than the updated patch in the first post, right?

//W

 

[Sebastiii]

Good question, i think i look both, because on pull request, some part was missing

 

[Sebastiii]

If i didn't look wrong, the patch from 1st post are the one in GIT Branch

 

[Wbunaarf]

Really? On line 17 in the teletextreceiver.diff patch in the first post the line 'if (page < 100) page += 800;' is added. I can't find this line in the BUG-branch. Am I missing something?

//W

 

[Sebastiii]

Thx you are right, i missing that line
I have look all 3 patch, i remember that i must patch manually the file because the diff didn't want to do his job and i forgot that line.
I will push the change

 

[Sebastiii]

Ok done,

The change has been pushed in the branch

 

[Sebastiii]

Really? On line 17 in the teletextreceiver.diff patch in the first post the line 'if (page < 100) page += 800;' is added. I can't find this line in the BUG-branch. Am I missing something?

//W

Can you reproduce the issue and with the fix, does it fix it for you ?
Thanks

 

[Wbunaarf]

I can confirm that I have subtitles on BBC Entertainment using the patch with this line present. Without the patch I have no idea, and I'm unfortunately not able to test it right know, but since jblomb has the issue it's a fair guess I would as well.

//W