Reply to thread

Message

<blockquote data-quote="MJGraf" data-source="post: 1164836" data-attributes="member: 17886">The answer is as easy as sad...The NfoMovieMDE does read the &lt;tmdbid&gt;, &lt;tmdbId&gt; and &lt;thmdb&gt; tags from nfo-files which may all contain the TheMovieDb-ID and stores it in MovieAspect.ATTR_TMDB_ID.But the MovieMDE (via OnlineLibraries) does not use MovieAspect.ATTR_TMDB_ID to find the movie online. It only <a href="https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/OnlineLibraries/MovieTheMovieDbMatcher.cs#L96" target="_blank">uses the IMDB-ID</a>, if present, or title and year if there is no IMDB-ID.The good news is that it shouldn't be too complicated to make it use the TmdbId for matching if any of the MDEs applied before has found one.In the link above, we need in addition to the MatchByImdbId-method a &quot;MatchByTmdbId&quot;-method.MatchByImdbId calls TheMovieDbWrapper.GetMovie(string imdbId, out Movie movieDetail), which online searches by IMDB-ID. But there is already a TheMovieDbWrapper.GetMovie(int id, out Movie movieDetail) method, which searches online by Tmdb-ID.So the changes should be limited to MovieTheMovieDbMatcher.I have no idea why this wasn't implemented before, but I suppose that when the MovieMDE was written, there were not too many ways to find such IDs, because the NfoMDEs were not yet there and IIRC also the Matroska-Tag-Reader was added later. And finding a Tmdb-ID by way of a string operation on the file or folder name is likely to fail, because it is just a number - without any identifying prefix like &quot;tt&quot;.Anyway - I will see what I can do...EDIT: MatroskaMatcher currently also only supports IMDB-ID - not TMDB-ID. But MatroskaReader, which is used by MatroskaMatcher, can read TMDB-ID from MKV-Files. So supporting this one as well (in case the TMDB-ID is tagged in the mkv-file, but there is no nfo-file) shouldn't be too complicated...</blockquote>

[QUOTE="MJGraf, post: 1164836, member: 17886"] The answer is as easy as sad... The NfoMovieMDE does read the <tmdbid>, <tmdbId> and <thmdb> tags from nfo-files which may all contain the TheMovieDb-ID and stores it in MovieAspect.ATTR_TMDB_ID. But the MovieMDE (via OnlineLibraries) does not use MovieAspect.ATTR_TMDB_ID to find the movie online. It only [URL='https://github.com/MediaPortal/MediaPortal-2/blob/dev/MediaPortal/Source/Extensions/MetadataExtractors/OnlineLibraries/MovieTheMovieDbMatcher.cs#L96']uses the IMDB-ID[/URL], if present, or title and year if there is no IMDB-ID. The good news is that it shouldn't be too complicated to make it use the TmdbId for matching if any of the MDEs applied before has found one. In the link above, we need in addition to the MatchByImdbId-method a "MatchByTmdbId"-method. MatchByImdbId calls TheMovieDbWrapper.GetMovie(string imdbId, out Movie movieDetail), which online searches by IMDB-ID. But there is already a TheMovieDbWrapper.GetMovie(int id, out Movie movieDetail) method, which searches online by Tmdb-ID. So the changes should be limited to MovieTheMovieDbMatcher. I have no idea why this wasn't implemented before, but I suppose that when the MovieMDE was written, there were not too many ways to find such IDs, because the NfoMDEs were not yet there and IIRC also the Matroska-Tag-Reader was added later. And finding a Tmdb-ID by way of a string operation on the file or folder name is likely to fail, because it is just a number - without any identifying prefix like "tt". Anyway - I will see what I can do... EDIT: MatroskaMatcher currently also only supports IMDB-ID - not TMDB-ID. But MatroskaReader, which is used by MatroskaMatcher, can read TMDB-ID from MKV-Files. So supporting this one as well (in case the TMDB-ID is tagged in the mkv-file, but there is no nfo-file) shouldn't be too complicated... [/QUOTE]

Verification