home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 2
General
this view could not be built
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="MJGraf" data-source="post: 1165670" data-attributes="member: 17886"><p>And here we go...</p><p>All changes from the issues discussed in this thread as pushed to a new <a href="https://github.com/MediaPortal/MediaPortal-2/tree/FEAT_MP2-505_Improve_NfoMovieMDE" target="_blank">branch on GitHub</a>.</p><p>The changes are supposed to solve the following issues: <a href="https://issues.team-mediaportal.com/browse/MP2-505" target="_blank">MP2-505</a>, <a href="https://issues.team-mediaportal.com/browse/MP2-507" target="_blank">MP2-507 </a>and <a href="https://issues.team-mediaportal.com/browse/MP2-509" target="_blank">MP2-509 </a>(see explanation on Jira).</p><p></p><p>The only thing mentioned here, that I have not (yet) implemented, is making the regular expressions in OnlineLibraries configurable via settings. The reason is that as far as I can see there is a lot that can be improved with these regular expressions when it comes to parsing file and path names for information such as title, year, disc number, etc. But currently, all the regular expressions used for that are spread across different plugins: VideoMDE, MusicMDE, MovieMDE, OnlineLibraries, SeriesMDE, etc.</p><p>What we should do IMHO sooner or later (i.e. as soon as we have a priority system for MDEs - note to self <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite2" alt=";)" title="Wink ;)" loading="lazy" data-shortname=";)" /> ) is put all this file and path name matching into a separate plugin (e.g. "PathMetadataExtractors", containing a PathMusicMDE, PathSeriesMDE, etc. That way we have all the logic (and regular expressions) used to parse a file or path name in one place. There I would make all regular expressions configurable via settings so that we have these settings in one place, which is MHO much better than having part of it in OnlineLibrariesSettings, another part in MovieMetadataExtractorSettings, etc.</p><p></p><p>As to the other changes from MP2-507, I have confirmed that our unit-tests all pass after the minimal change to the TitleYear-Regex.</p><p></p><p>Binaries are attached. As usual, stop MP2-Server, replace all files with the ones contained in the attached 7z-file, restart MP2-Server and add a MediaSource to test.</p><p>[USER=109222]@Lehmden[/USER] : As mentioned it would be helpful if you could in particular test the following scenarios:</p><ul> <li data-xf-list-type="ul">mkv-movie-file without nfo-file, random mkv-file-name and only tmdb-id tagged into mkv.</li> <li data-xf-list-type="ul">mkv-movie-file without any mkv-tags, random mkv-file-name but with a corresponding nfo-file only containing a <tmdbid> element.</li> <li data-xf-list-type="ul">mkv-series-file without nfo-file, random mkv-file name and only t<strong><u>v</u></strong>db-id, season number and episode number tagged into the mkv file (to make sure it still works).</li> </ul><p>[USER=87223]@JSchuricht[/USER] : Instead of the binaries above, you can use the ones attached to this post. But you still need to add "imdb" to MovieNfoFileNames in NfoMovieMetadataExtractorSettings.xml to make it work for you.</p><p>Thinking about it: [USER=109222]@Lehmden[/USER]: is there a reason not to include "imdb" as additional "nfo"-file name by default? Currently, if there is no nfo-file with the same name as the video file, it searches for movie.nfo, movie.txt and movie.xml. By adding "imdb", it would also search for imdb.nfo, imdb.txt and imdb.xml.</p><p>Is any of these file names common?</p></blockquote><p></p>
[QUOTE="MJGraf, post: 1165670, member: 17886"] And here we go... All changes from the issues discussed in this thread as pushed to a new [URL='https://github.com/MediaPortal/MediaPortal-2/tree/FEAT_MP2-505_Improve_NfoMovieMDE']branch on GitHub[/URL]. The changes are supposed to solve the following issues: [URL='https://issues.team-mediaportal.com/browse/MP2-505']MP2-505[/URL], [URL='https://issues.team-mediaportal.com/browse/MP2-507']MP2-507 [/URL]and [URL='https://issues.team-mediaportal.com/browse/MP2-509']MP2-509 [/URL](see explanation on Jira). The only thing mentioned here, that I have not (yet) implemented, is making the regular expressions in OnlineLibraries configurable via settings. The reason is that as far as I can see there is a lot that can be improved with these regular expressions when it comes to parsing file and path names for information such as title, year, disc number, etc. But currently, all the regular expressions used for that are spread across different plugins: VideoMDE, MusicMDE, MovieMDE, OnlineLibraries, SeriesMDE, etc. What we should do IMHO sooner or later (i.e. as soon as we have a priority system for MDEs - note to self ;) ) is put all this file and path name matching into a separate plugin (e.g. "PathMetadataExtractors", containing a PathMusicMDE, PathSeriesMDE, etc. That way we have all the logic (and regular expressions) used to parse a file or path name in one place. There I would make all regular expressions configurable via settings so that we have these settings in one place, which is MHO much better than having part of it in OnlineLibrariesSettings, another part in MovieMetadataExtractorSettings, etc. As to the other changes from MP2-507, I have confirmed that our unit-tests all pass after the minimal change to the TitleYear-Regex. Binaries are attached. As usual, stop MP2-Server, replace all files with the ones contained in the attached 7z-file, restart MP2-Server and add a MediaSource to test. [USER=109222]@Lehmden[/USER] : As mentioned it would be helpful if you could in particular test the following scenarios: [LIST] [*]mkv-movie-file without nfo-file, random mkv-file-name and only tmdb-id tagged into mkv. [*]mkv-movie-file without any mkv-tags, random mkv-file-name but with a corresponding nfo-file only containing a <tmdbid> element. [*]mkv-series-file without nfo-file, random mkv-file name and only t[B][U]v[/U][/B]db-id, season number and episode number tagged into the mkv file (to make sure it still works). [/LIST] [USER=87223]@JSchuricht[/USER] : Instead of the binaries above, you can use the ones attached to this post. But you still need to add "imdb" to MovieNfoFileNames in NfoMovieMetadataExtractorSettings.xml to make it work for you. Thinking about it: [USER=109222]@Lehmden[/USER]: is there a reason not to include "imdb" as additional "nfo"-file name by default? Currently, if there is no nfo-file with the same name as the video file, it searches for movie.nfo, movie.txt and movie.xml. By adding "imdb", it would also search for imdb.nfo, imdb.txt and imdb.xml. Is any of these file names common? [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 2
General
this view could not be built
Contact us
RSS
Top
Bottom