Reply to thread

Message

<blockquote data-quote="morpheus_xx" data-source="post: 1179534" data-attributes="member: 48495">And I have some further comments for better skin code-style:<ul>
<li data-xf-list-type="ul">If you check for string&nbsp; Width=&quot;380&quot;, you will find 10 references. Please introduce a constant i.e. CoverWidth (or use an existing one for this).</li>
<li data-xf-list-type="ul">Same for Height=&quot;520&quot;</li>
<li data-xf-list-type="ul">Same for Margin=&quot;27,-7,17,30&quot;</li>
<li data-xf-list-type="ul">Please include all files from folder in the TE project file</li>
<li data-xf-list-type="ul">[2016-03-23 18:46:33,997] [854873 ] [DX Render] [WARN ] - Cannot open texture: FallbackFanart.png</li>
</ul>Once you do this, you will find that the different screens between your themes are suddenly much more similar and you could avoid many single changes and redundant files. As a general rule, whenever you type the same number for same purpose more than once, introduce a resource.</blockquote>

[QUOTE="morpheus_xx, post: 1179534, member: 48495"] And I have some further comments for better skin code-style: [LIST] [*]If you check for string [I]Width="380"[/I], you will find 10 references. Please introduce a constant i.e. CoverWidth (or use an existing one for this). [*]Same for [I]Height="520"[/I] [*]Same for [I]Margin="27,-7,17,30"[/I] [*]Please include [B]all [/B]files from folder in the TE project file [*][2016-03-23 18:46:33,997] [854873 ] [DX Render] [WARN ] - Cannot open texture: FallbackFanart.png [/LIST] Once you do this, you will find that the different screens between your themes are suddenly much more similar and you could avoid many single changes and redundant files. As a general rule, whenever you type the same number for same purpose more than once, introduce a resource. [/QUOTE]

Verification