Reply to thread

Message

<blockquote data-quote="morpheus_xx" data-source="post: 1152349" data-attributes="member: 48495">First things to notice are the existings code parts in MP2:<ul>
<li data-xf-list-type="ul">Trakt client plugin: <a href="https://github.com/MediaPortal/MediaPortal-2/tree/1fcf783e56c55e96ae9c0e490a4b5b5b7be5487f/MediaPortal/Incubator/Trakt" target="_blank">https://github.com/MediaPortal/MediaPortal-2/tree/1fcf783e56c55e96ae9c0e490a4b5b5b7be5487f/MediaPortal/Incubator/Trakt</a></li>
<li data-xf-list-type="ul">OnlineLibraries project with &quot;old&quot; trakt API: <a href="https://github.com/MediaPortal/MediaPortal-2/tree/1fcf783e56c55e96ae9c0e490a4b5b5b7be5487f/MediaPortal/Source/Extensions/MetadataExtractors/OnlineLibraries/Libraries/Trakt" target="_blank">https://github.com/MediaPortal/MediaPortal-2/tree/1fcf783e56c55e96ae9c0e490a4b5b5b7be5487f/MediaPortal/Source/Extensions/MetadataExtractors/OnlineLibraries/Libraries/Trakt</a></li>
</ul>I remember that I modified the sources of the copy in MP2 a bit, mainly cleanups for code guidelines and small refactorings: <a href="https://github.com/MediaPortal/MediaPortal-2/commits/1fcf783e56c55e96ae9c0e490a4b5b5b7be5487f/MediaPortal/Source/Extensions/MetadataExtractors/OnlineLibraries/Libraries/Trakt" target="_blank">https://github.com/MediaPortal/MediaPortal-2/commits/1fcf783e56c55e96ae9c0e490a4b5b5b7be5487f/MediaPortal/Source/Extensions/MetadataExtractors/OnlineLibraries/Libraries/Trakt</a>.I'm not sure how to proceed with this. If we now copy over the changes from MP1 based project again, we will end with two different versions (like we already have). That's why I'd prefer to have a nuget package which contains a common API library, that we could include in the MP2 specific client plugin.</blockquote>

[QUOTE="morpheus_xx, post: 1152349, member: 48495"] First things to notice are the existings code parts in MP2: [LIST] [*]Trakt client plugin: [URL]https://github.com/MediaPortal/MediaPortal-2/tree/1fcf783e56c55e96ae9c0e490a4b5b5b7be5487f/MediaPortal/Incubator/Trakt[/URL] [*]OnlineLibraries project with "old" trakt API: [URL]https://github.com/MediaPortal/MediaPortal-2/tree/1fcf783e56c55e96ae9c0e490a4b5b5b7be5487f/MediaPortal/Source/Extensions/MetadataExtractors/OnlineLibraries/Libraries/Trakt[/URL] [/LIST] I remember that I modified the sources of the copy in MP2 a bit, mainly cleanups for code guidelines and small refactorings: [URL]https://github.com/MediaPortal/MediaPortal-2/commits/1fcf783e56c55e96ae9c0e490a4b5b5b7be5487f/MediaPortal/Source/Extensions/MetadataExtractors/OnlineLibraries/Libraries/Trakt[/URL]. I'm not sure how to proceed with this. If we now copy over the changes from MP1 based project again, we will end with two different versions (like we already have). That's why I'd prefer to have a nuget package which contains a common API library, that we could include in the MP2 specific client plugin. [/QUOTE]

Verification