home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 2
Plugin Development
Trakt for MP2
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="morpheus_xx" data-source="post: 1153132" data-attributes="member: 48495"><p>Thanks [USER=72523]@aspik[/USER] <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite24" alt="(y)" title="Thumbs Up (y)" loading="lazy" data-shortname="(y)" /></p><p></p><p>A full answer will require more time, but I want to let you know that I've read it.</p><p></p><p>I have some small requests:</p><ul> <li data-xf-list-type="ul">Can you please install the VS extension "EditorConfig". It should take care to apply the MP rules for spaces. This will save a lot of differences due to 4/2 space indentation</li> <li data-xf-list-type="ul">Then please create a new patch</li> </ul><p></p><p></p><p>This project is out of date and does not compile. Usually it is disabled for build in both DEBUG and RELEASE configs. No need to worry about errors there.</p><p></p><p></p><p>To keep the changes inside all other classes at a minimum, we could have an "own" implementation of TraktLogger with same public interface, but forwarding logging to the ILogger from ServiceRegistration.</p><p></p><p>The other points need some more time to check...</p></blockquote><p></p>
[QUOTE="morpheus_xx, post: 1153132, member: 48495"] Thanks [USER=72523]@aspik[/USER] (y) A full answer will require more time, but I want to let you know that I've read it. I have some small requests: [LIST] [*]Can you please install the VS extension "EditorConfig". It should take care to apply the MP rules for spaces. This will save a lot of differences due to 4/2 space indentation [*]Then please create a new patch [/LIST] This project is out of date and does not compile. Usually it is disabled for build in both DEBUG and RELEASE configs. No need to worry about errors there. To keep the changes inside all other classes at a minimum, we could have an "own" implementation of TraktLogger with same public interface, but forwarding logging to the ILogger from ServiceRegistration. The other points need some more time to check... [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 2
Plugin Development
Trakt for MP2
Contact us
RSS
Top
Bottom