Reply to thread

Message

<blockquote data-quote="aspik" data-source="post: 1246206" data-attributes="member: 72523">I did this and the SetUnwatchedAction gets the UserMedia data, but I'm still not sure if this helps me to determine if a MI was watched or not.This <a href="https://github.com/MediaPortal/MediaPortal-2/blob/WIP_2.2/MediaPortal/Source/UI/UiComponents/Media/MediaItemActions/AbstractWatchedAction.cs#L59-L90" target="_blank">ProcessAsync</a> method gets called from my MarkAsWatched/MarkAsUnwatched methods, as well as when invoking the set played and set unplayed actions from the client UI. So, I tested it without trakt, just by applying the MP2 UI actions. The PlayCount from the UserData property is still unchanged when using the UI actions.Looking at the ProcessAsync method shows, that it can't change the play count, because it's missing in the argument list of the <a href="https://github.com/MediaPortal/MediaPortal-2/blob/WIP_2.2/MediaPortal/Source/UI/UiComponents/Media/MediaItemActions/AbstractWatchedAction.cs#L80" target="_blank">NotifyUserPlaybackAsync</a> method:[code=csharp]if (userProfile.HasValue){&nbsp; await cd.NotifyUserPlaybackAsync(userProfile.Value, mediaItem.MediaItemId, playPercentage, watched);}[/code]I think this method needs to be extended by a playCount, something like this:[SPOILER][code=csharp]public async Task NotifyUserPlaybackAsync(Guid userId, Guid mediaItemId, int percentage, int playCount, bool updatePlayDate = true){&nbsp; CpAction action = GetAction(&quot;X_MediaPortal_NotifyUserPlayback&quot;);&nbsp; IList&lt;object&gt; inParameters = new List&lt;object&gt;&nbsp; {&nbsp; &nbsp; MarshallingHelper.SerializeGuid(userId),&nbsp; &nbsp; MarshallingHelper.SerializeGuid(mediaItemId),&nbsp; &nbsp; percentage,&nbsp; &nbsp; playCount,&nbsp; &nbsp; updatePlayDate&nbsp; };&nbsp; await action.InvokeAsync(inParameters);}[/code][/SPOILER]and in the <a href="https://github.com/MediaPortal/MediaPortal-2/blob/WIP_2.2/MediaPortal/Source/Core/MediaPortal.Backend/Services/ClientCommunication/UPnPContentDirectoryServiceImpl.cs#L1088-L1093" target="_blank">UPnPContentDirectoryServiceImpl</a>[SPOILER][code=csharp]DvAction mpnp11NotifyUserPlaybackAction = new DvAction(&quot;X_MediaPortal_NotifyUserPlayback&quot;, OnMPnP11NotifyUserPlayback,&nbsp; &nbsp; new DvArgument[] {&nbsp; &nbsp; &nbsp; new DvArgument(&quot;UserProfile&quot;, A_ARG_TYPE_Uuid, ArgumentDirection.In),&nbsp; &nbsp; &nbsp; new DvArgument(&quot;MediaItemId&quot;, A_ARG_TYPE_Uuid, ArgumentDirection.In),&nbsp; &nbsp; &nbsp; new DvArgument(&quot;Percentage&quot;, A_ARG_TYPE_Integer, ArgumentDirection.In),&nbsp; &nbsp; &nbsp; new DvArgument(&quot;PlayCount&quot;, A_ARG_TYPE_Integer, ArgumentDirection.In),&nbsp; &nbsp; &nbsp; new DvArgument(&quot;UpdatePlayDate&quot;, A_ARG_TYPE_Bool, ArgumentDirection.In),&nbsp; &nbsp; },[/code][/SPOILER]What do you think?</blockquote>

[QUOTE="aspik, post: 1246206, member: 72523"] I did this and the SetUnwatchedAction gets the UserMedia data, but I'm still not sure if this helps me to determine if a MI was watched or not. This [URL='https://github.com/MediaPortal/MediaPortal-2/blob/WIP_2.2/MediaPortal/Source/UI/UiComponents/Media/MediaItemActions/AbstractWatchedAction.cs#L59-L90']ProcessAsync[/URL] method gets called from my MarkAsWatched/MarkAsUnwatched methods, as well as when invoking the set played and set unplayed actions from the client UI. So, I tested it without trakt, just by applying the MP2 UI actions. The PlayCount from the UserData property is still unchanged when using the UI actions. Looking at the ProcessAsync method shows, that it can't change the play count, because it's missing in the argument list of the [URL='https://github.com/MediaPortal/MediaPortal-2/blob/WIP_2.2/MediaPortal/Source/UI/UiComponents/Media/MediaItemActions/AbstractWatchedAction.cs#L80']NotifyUserPlaybackAsync[/URL] method: [code=csharp]if (userProfile.HasValue) { await cd.NotifyUserPlaybackAsync(userProfile.Value, mediaItem.MediaItemId, playPercentage, watched); }[/code] I think this method needs to be extended by a playCount, something like this: [SPOILER][code=csharp]public async Task NotifyUserPlaybackAsync(Guid userId, Guid mediaItemId, int percentage, int playCount, bool updatePlayDate = true) { CpAction action = GetAction("X_MediaPortal_NotifyUserPlayback"); IList<object> inParameters = new List<object> { MarshallingHelper.SerializeGuid(userId), MarshallingHelper.SerializeGuid(mediaItemId), percentage, playCount, updatePlayDate }; await action.InvokeAsync(inParameters); }[/code][/SPOILER] and in the [URL='https://github.com/MediaPortal/MediaPortal-2/blob/WIP_2.2/MediaPortal/Source/Core/MediaPortal.Backend/Services/ClientCommunication/UPnPContentDirectoryServiceImpl.cs#L1088-L1093']UPnPContentDirectoryServiceImpl[/URL] [SPOILER][code=csharp]DvAction mpnp11NotifyUserPlaybackAction = new DvAction("X_MediaPortal_NotifyUserPlayback", OnMPnP11NotifyUserPlayback, new DvArgument[] { new DvArgument("UserProfile", A_ARG_TYPE_Uuid, ArgumentDirection.In), new DvArgument("MediaItemId", A_ARG_TYPE_Uuid, ArgumentDirection.In), new DvArgument("Percentage", A_ARG_TYPE_Integer, ArgumentDirection.In), new DvArgument("PlayCount", A_ARG_TYPE_Integer, ArgumentDirection.In), new DvArgument("UpdatePlayDate", A_ARG_TYPE_Bool, ArgumentDirection.In), },[/code][/SPOILER] What do you think? [/QUOTE]

Verification