Reply to thread

Message

<blockquote data-quote="foxbenw" data-source="post: 843212" data-attributes="member: 115475">So far i haven't seen any case where we would want to use episode part and episode name separately. I don't know if it is better to have it separately for future use, or wait until someone needs it.In the MP plugin are the last 4 options for the manual override? Or do they change the default setting? I can't quite picture it from what you have written.I don't understand why you need two sets of code. Shouldn't automatic be the same as manual, except useDescription etc take some default value? The way you have it now, the blanks will be treated differently for each. Perhaps that is on purpose. I think this might explain why in one of my previous posts the 'fresh meat' wish was returning skip = true. useDescription = false, default = true, and episodeName and episode/seriesNumber were blank. Also, using this code, if useDescription = useName = usePart = useNumbers = falsethe program is skipped?You may need to change the last nested if statement to allow for that.Before I saw what you had written I think something like this was what was in my head. The logic between the criteria is OR not AND. ie any match on a criteria is enough to skip, rather than all of them having to match. I assume you have thought about it and rejected this for some reason in the past! Sorry if anything is wrong, I have only ever done amateur VBA.if ((newDescription == oldDescription) &amp;&amp; (newDescription != string.Empty) &amp;&amp; (useDescription) ){&nbsp;return true;}if ((newSeriesNumber == oldSeriesNumber) &amp;&amp; (newSeriesNumber != string.Empty) &amp;&amp; (useNumbers) ){&nbsp; if ((newEpisodeNumber != string.Empty) &amp;&amp; (newEpisodeNumber == oldEpisodeNumber)) {&nbsp; &nbsp; return true;&nbsp; }}// if series number exists but there is no episode number it will not skip.if ((newEpisodeName == oldEpisodeName) &amp;&amp; (newEpisodeName != string.Empty) &amp;&amp; (useNames) ){&nbsp; if ((newEpisodePart == string.Empty) || (newEpisodePart == oldEpisodePart)) {&nbsp; &nbsp; return true;&nbsp; }}//different to numbers. an empty episode part allows for skipping.return false;Ben</blockquote>

[QUOTE="foxbenw, post: 843212, member: 115475"] So far i haven't seen any case where we would want to use episode part and episode name separately. I don't know if it is better to have it separately for future use, or wait until someone needs it. In the MP plugin are the last 4 options for the manual override? Or do they change the default setting? I can't quite picture it from what you have written. I don't understand why you need two sets of code. Shouldn't automatic be the same as manual, except useDescription etc take some default value? The way you have it now, the blanks will be treated differently for each. Perhaps that is on purpose. I think this might explain why in one of my previous posts the 'fresh meat' wish was returning skip = true. useDescription = false, default = true, and episodeName and episode/seriesNumber were blank. Also, using this code, if useDescription = useName = usePart = useNumbers = false the program is skipped? You may need to change the last nested if statement to allow for that. Before I saw what you had written I think something like this was what was in my head. The logic between the criteria is OR not AND. ie any match on a criteria is enough to skip, rather than all of them having to match. I assume you have thought about it and rejected this for some reason in the past! Sorry if anything is wrong, I have only ever done amateur VBA. if ((newDescription == oldDescription) && (newDescription != string.Empty) && (useDescription) ) { return true; } if ((newSeriesNumber == oldSeriesNumber) && (newSeriesNumber != string.Empty) && (useNumbers) ) { if ((newEpisodeNumber != string.Empty) && (newEpisodeNumber == oldEpisodeNumber)) { return true; } }// if series number exists but there is no episode number it will not skip. if ((newEpisodeName == oldEpisodeName) && (newEpisodeName != string.Empty) && (useNames) ) { if ((newEpisodePart == string.Empty) || (newEpisodePart == oldEpisodePart)) { return true; } }//different to numbers. an empty episode part allows for skipping. return false; Ben [/QUOTE]

Verification