Reply to thread

Message

<blockquote data-quote="huha" data-source="post: 843270" data-attributes="member: 63847">Ben,- the last four options in the MP plugin are for the overwrite of a single tv wish, not the defaults.- in my code the episode would be skipped if all matching criteria are disabled and the title is the same. I thaught it is important to give the user a choice to skip based on a title match only.-Ok, I see here we had a major misunderstanding with the AND and OR conjunction for matching criteria.The reason i came up with AND was that there were a lot of EPG data which had the same description for all episodes.So you can say that´s why the user can disable the description. But based on your proposal what do you think about the following version?if (useNumbers) //check for seriesnumber and episodenumber must be first&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if ((newSeriesNumber == oldSeriesNumber) &amp;&amp; (newSeriesNumber != string.Empty))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if ((newEpisodeNumber == oldEpisodeNumber)&amp;&amp;(newEpisodeNumber != string.Empty) ) &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return true; //series number and episode number do match&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else if ((newEpisodeNumber != oldEpisodeNumber) &amp;&amp; (newEpisodeNumber != string.Empty) &amp;&amp; (oldEpisodeNumber != string.Empty))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false; //true mismatch of episodenumber&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }// if series number exists but there is no episode number it will not skip.&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else if ((newSeriesNumber != oldSeriesNumber) &amp;&amp; (newSeriesNumber != string.Empty) &amp;&amp; (oldSeriesNumber != string.Empty))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false; //true mismatch of series number&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (useName) //check for episode name and episode part &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if ((newEpisodeName == oldEpisodeName) &amp;&amp; (newEpisodeName != string.Empty))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if ((newEpisodePart == oldEpisodePart) || (newEpisodePart == string.Empty))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return true;&nbsp; //Episode name is matching and episode part is matching or is empty&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else if ((newEpisodePart != oldEpisodePart) &amp;&amp; (newEpisodePart != string.Empty) &amp;&amp; (oldEpisodePart != string.Empty))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false; //true mismatch of episodepart&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else if ((newEpisodeName != oldEpisodeName) &amp;&amp; (newEpisodeName != string.Empty) &amp;&amp; (oldEpisodeName != string.Empty))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false; //true mismatch of episodename&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (useDescription) //check for description must be last &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if ((newDescription == oldDescription) &amp;&amp; (newDescription != string.Empty) )&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return true; //Description is matching&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (!useNumbers &amp;&amp; !useName &amp;&amp; !useDescription)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return true; //enables the user to skip just for identical title if nothing is checked, skip repeated checkbox still needed&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; return false;&nbsp; //no unique matches or mismatches&nbsp; do not know&nbsp; &nbsp; &nbsp; &nbsp; }</blockquote>

[QUOTE="huha, post: 843270, member: 63847"] Ben, - the last four options in the MP plugin are for the overwrite of a single tv wish, not the defaults. - in my code the episode would be skipped if all matching criteria are disabled and the title is the same. I thaught it is important to give the user a choice to skip based on a title match only. -Ok, I see here we had a major misunderstanding with the AND and OR conjunction for matching criteria. The reason i came up with AND was that there were a lot of EPG data which had the same description for all episodes. So you can say that´s why the user can disable the description. But based on your proposal what do you think about the following version? if (useNumbers) //check for seriesnumber and episodenumber must be first { if ((newSeriesNumber == oldSeriesNumber) && (newSeriesNumber != string.Empty)) { if ((newEpisodeNumber == oldEpisodeNumber)&&(newEpisodeNumber != string.Empty) ) { return true; //series number and episode number do match } else if ((newEpisodeNumber != oldEpisodeNumber) && (newEpisodeNumber != string.Empty) && (oldEpisodeNumber != string.Empty)) { return false; //true mismatch of episodenumber } }// if series number exists but there is no episode number it will not skip. else if ((newSeriesNumber != oldSeriesNumber) && (newSeriesNumber != string.Empty) && (oldSeriesNumber != string.Empty)) { return false; //true mismatch of series number } } if (useName) //check for episode name and episode part { if ((newEpisodeName == oldEpisodeName) && (newEpisodeName != string.Empty)) { if ((newEpisodePart == oldEpisodePart) || (newEpisodePart == string.Empty)) { return true; //Episode name is matching and episode part is matching or is empty } else if ((newEpisodePart != oldEpisodePart) && (newEpisodePart != string.Empty) && (oldEpisodePart != string.Empty)) { return false; //true mismatch of episodepart } } else if ((newEpisodeName != oldEpisodeName) && (newEpisodeName != string.Empty) && (oldEpisodeName != string.Empty)) { return false; //true mismatch of episodename } } if (useDescription) //check for description must be last { if ((newDescription == oldDescription) && (newDescription != string.Empty) ) { return true; //Description is matching } } if (!useNumbers && !useName && !useDescription) { return true; //enables the user to skip just for identical title if nothing is checked, skip repeated checkbox still needed } return false; //no unique matches or mismatches do not know } [/QUOTE]

Verification