Reply to thread

Message

<blockquote data-quote="Sebastiii" data-source="post: 1171625" data-attributes="member: 60104">Ok, now i remember when debugging the original issue, we have this in \mediaportal\Core\guilib\GUITextScrollUpControl.cs :The '_containsProperty' is set to true when and only when the property start with #......So for ex :&lt;define property=&quot;true&quot; evaluateNow=&quot;false&quot;&gt;#desc.text: Dean is surprised when he checks Bobbys cell phone and hears a message that says Bobby or his next of kin have been named as a beneficiary in an heiress will. Hoping that means extra money, Dean talks Sam into hitting the road to claim their fortune. However, what they encounter at the house is far from a treasure chest. &lt;/define&gt;This property start with #desc.text, so when GUITextScrollUpControl code detect #desc.text, _containsProperty is true and then the text is displayed.The fix from Jira, does that :[code=csharp]if (text.Length &gt; 0 &amp;&amp; text[0] == '#' &amp;&amp; control.Type != &quot;textboxscrollup&quot;)&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; string foundDefine = null;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (defines.TryGetValue(text, out foundDefine))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; text = foundDefine;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; else&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; if (_cachedDefines.TryGetValue(text, out foundDefine))&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; {&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; text = foundDefine;&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; }[/code]If the property start with # (here #desc.text) we will not try to look/search if #desc.text contain a define value (the text : Dean is surprised .....) because if the property will be converted to a text (here), the code from GUITextScrollUpControl will not be used and then nothing displayed.To summarize :Before the Jira, the property was checked and if a define value was found, the property was converted to the text and then textboxscrollup display nothing.With the Jira, it doesn't try to convert/find a define from the property and then textboxscrollup does his job and do the convertion.But now in your example, it seems that we need to convert the property with the correspondent value like you can see it working on 1.12.So i don't know what to do right now lol</blockquote>

[QUOTE="Sebastiii, post: 1171625, member: 60104"] Ok, now i remember when debugging the original issue, we have this in \mediaportal\Core\guilib\GUITextScrollUpControl.cs : The '_containsProperty' is set to true when and only when the property start with #...... So for ex : <define property="true" evaluateNow="false">#desc.text: Dean is surprised when he checks Bobbys cell phone and hears a message that says Bobby or his next of kin have been named as a beneficiary in an heiress will. Hoping that means extra money, Dean talks Sam into hitting the road to claim their fortune. However, what they encounter at the house is far from a treasure chest. </define> This property start with #desc.text, so when GUITextScrollUpControl code detect #desc.text, _containsProperty is true and then the text is displayed. The fix from Jira, does that : [code=csharp]if (text.Length > 0 && text[0] == '#' && control.Type != "textboxscrollup") { string foundDefine = null; if (defines.TryGetValue(text, out foundDefine)) { text = foundDefine; } else { if (_cachedDefines.TryGetValue(text, out foundDefine)) { text = foundDefine; } } }[/code] If the property start with # (here #desc.text) we will not try to look/search if #desc.text contain a define value (the text : Dean is surprised .....) because if the property will be converted to a text (here), the code from GUITextScrollUpControl will not be used and then nothing displayed. To summarize : Before the Jira, the property was checked and if a define value was found, the property was converted to the text and then textboxscrollup display nothing. With the Jira, it doesn't try to convert/find a define from the property and then textboxscrollup does his job and do the convertion. But now in your example, it seems that we need to convert the property with the correspondent value like you can see it working on 1.12. So i don't know what to do right now lol [/QUOTE]

Verification