home
products
contribute
download
documentation
forum
Home
Forums
New posts
Search forums
What's new
New posts
All posts
Latest activity
Members
Registered members
Current visitors
Donate
Log in
Register
What's new
Search
Search
Search titles only
By:
New posts
Search forums
Search titles only
By:
Menu
Log in
Register
Navigation
Install the app
Install
More options
Contact us
Close Menu
Forums
MediaPortal 1
Development
General Development (no feature request here!)
Usage of Git by MediaPortal
Contact us
RSS
JavaScript is disabled. For a better experience, please enable JavaScript in your browser before proceeding.
You are using an out of date browser. It may not display this or other websites correctly.
You should upgrade or use an
alternative browser
.
Reply to thread
Message
<blockquote data-quote="tourettes" data-source="post: 835889" data-attributes="member: 10858"><p>Yes, those should be deleted (it is also stated in the internal workflow documentation (which should be probably published <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile :)" loading="lazy" data-shortname=":)" />)). The reason why they are still there is that the fixes weren't merged to the master at the same time when they were merged to the 1.2.x branch - there was huge bulk of extra work for gathering and handling all the SVN based error fixes after GIT migration was done. Currently we are lacking a bit on the developers - everyone has their hands full of things to do (mostly in the non-MP areas).</p><p></p><p></p><p></p><p>There was error in the workflow indeed. Master branch shouldn't ever had been used as the base for creating the error fixes. We noticed that when majority of fixes were transfered from the SVN era to the GIT era and didn't see a need for re-doing all that work. After all all those bug fix branches should be at end of their life when they have merged to the 1.2.x and master.</p><p></p><p></p><p></p><p>Do not ask from me why it was created like that <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile :)" loading="lazy" data-shortname=":)" /> Maybe to test how the 3rd party developer pull request are handled in the future?</p></blockquote><p></p>
[QUOTE="tourettes, post: 835889, member: 10858"] Yes, those should be deleted (it is also stated in the internal workflow documentation (which should be probably published :))). The reason why they are still there is that the fixes weren't merged to the master at the same time when they were merged to the 1.2.x branch - there was huge bulk of extra work for gathering and handling all the SVN based error fixes after GIT migration was done. Currently we are lacking a bit on the developers - everyone has their hands full of things to do (mostly in the non-MP areas). There was error in the workflow indeed. Master branch shouldn't ever had been used as the base for creating the error fixes. We noticed that when majority of fixes were transfered from the SVN era to the GIT era and didn't see a need for re-doing all that work. After all all those bug fix branches should be at end of their life when they have merged to the 1.2.x and master. Do not ask from me why it was created like that :) Maybe to test how the 3rd party developer pull request are handled in the future? [/QUOTE]
Insert quotes…
Verification
Post reply
Forums
MediaPortal 1
Development
General Development (no feature request here!)
Usage of Git by MediaPortal
Contact us
RSS
Top
Bottom