Reply to thread

Message

<blockquote data-quote="Oxan" data-source="post: 751306" data-attributes="member: 97484">Currently there's a lot of code duplication in the web service. Most methods open the database, execute a query, loop through the results and select a subset of it (_start and _end), and close the database. This isn't very good for code readability. I've created an experimental patch for this: it creates a Database class, which handles the standard method calls. I've been able to reduce the size of MPTvSeries.cs with almost 40%, but more importantly, the code is a lot cleaner (for example removal of the -99 magic number). It shouldn't have any effect on users as the API isn't changed, but only the internal code. I can cleanup the other classes also, but the patch is already quite big and I want to avoid to create an monster-patch which is un-updatable (is that even a word?).Mike: the WebMediaPortal patches will come soon too, working on it now <img src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" class="smilie smilie--sprite smilie--sprite1" alt=":)" title="Smile&nbsp; &nbsp; :)" loading="lazy" data-shortname=":)" /></blockquote>

[QUOTE="Oxan, post: 751306, member: 97484"] Currently there's a lot of code duplication in the web service. Most methods open the database, execute a query, loop through the results and select a subset of it (_start and _end), and close the database. This isn't very good for code readability. I've created an experimental patch for this: it creates a Database class, which handles the standard method calls. I've been able to reduce the size of MPTvSeries.cs with almost 40%, but more importantly, the code is a lot cleaner (for example removal of the -99 magic number). It shouldn't have any effect on users as the API isn't changed, but only the internal code. I can cleanup the other classes also, but the patch is already quite big and I want to avoid to create an monster-patch which is un-updatable (is that even a word?). Mike: the WebMediaPortal patches will come soon too, working on it now :) [/QUOTE]

Verification