Worlds greatest bot!
- March 26, 2007
When GUIControlFactory updates a control it performs type conversions from string to a target type (int, bool, etc). At the moment the exceptions are handled internal to GUIControlFactory on each attempt to create the control. The problem is that the window never receives notice that the control couldn't be created properly and so the window keeps trying to create the broken control resulting in MP freezing while trying to load the window. By throwing the exception to the GUIWindow the window can remove the offending control from its list of controls and log a debug error. Without this change the skin developer needs to kill MP and manually hunt through the window xml to find the problem (the logs are not useful). With this change you can leave MP running and simply edit the xml file (with good log info) and retry.