1.27 Pre Clients crash (2 Viewers)

[ajs]

@yartat say:

The last thing I changed in the latest version is the compilation with AVX instructions (appeared for Intel with Sandy Bridge and for AMD with Bulldozer). Previously I compiled with SSE2. I have no problem to prepare new build with SSE2

New MediaInfo with SSE2 in attach, worked fine for me

 

[Sebastiii]

Hi
Have to try, I just upgraded on 1.27Pre and MP crash on MediaInfo dll at least for TVSeries, but I'm pretty sure for other too :

[2020-12-19 13:14:25,424] [Error ] [58 ] [ERROR] - MediaPortal: Unhandled exception occured
[2020-12-19 13:14:25,437] [Log ] [58 ] [ERROR] - Exception: System.Reflection.TargetInvocationException: An exception occurred during the operation, making the result invalid. Check InnerException for exception details. ---> System.DllNotFoundException: Unable to load DLL 'MediaInfo.dll': A dynamic link library (DLL) initialization routine failed. (Exception from HRESULT: 0x8007045A)
at WindowPlugins.GUITVSeries.MediaInfoLib.MediaInfo.MediaInfption(IntPtr Handle, String Option, String Value)
at WindowPlugins.GUITVSeries.MediaInfoLib.MediaInfo.GetInstance()
at WindowPlugins.GUITVSeries.DBEpisode.ReadMediaInfo()
at WindowPlugins.GUITVSeries.OnlineParsing.asyncReadResolutions(Object sender, DoWorkEventArgs e)
at System.ComponentModel.BackgroundWorker.OnDoWork(DoWorkEventArgs e)
at System.ComponentModel.BackgroundWorker.WorkerThreadStart(Object argument)
--- End of inner exception stack trace ---
at System.ComponentModel.AsyncCompletedEventArgs.RaiseExceptionIfNecessary()
at WindowPlugins.GUITVSeries.OnlineParsing.asyncReadResolutionsCompleted(Object sender, RunWorkerCompletedEventArgs e)
at System.ComponentModel.BackgroundWorker.OnRunWorkerCompleted(RunWorkerCompletedEventArgs e)
at System.ComponentModel.BackgroundWorker.AsyncOperationCompleted(Object arg)
at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback() Message: An exception occurred during the operation, making the result invalid. Check InnerException for exception details. Site : Void RaiseExceptionIfNecessary() Source : System Inner Exception(s): -> An exception occurred during the operation, making the result invalid. Check InnerException for exception details. -> Unable to load DLL 'MediaInfo.dll': A dynamic link library (DLL) initialization routine failed. (Exception from HRESULT: 0x8007045A) Stack Trace: at System.ComponentModel.AsyncCompletedEventArgs.RaiseExceptionIfNecessary()
at WindowPlugins.GUITVSeries.OnlineParsing.asyncReadResolutionsCompleted(Object sender, RunWorkerCompletedEventArgs e)
at System.ComponentModel.BackgroundWorker.OnRunWorkerCompleted(RunWorkerCompletedEventArgs e)
at System.ComponentModel.BackgroundWorker.AsyncOperationCompleted(Object arg)
at System.Threading.QueueUserWorkItemCallback.WaitCallback_Context(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading._ThreadPoolWaitCallback.PerformWaitCallback()

Will try @ajs new MediaInfo dll to see how it goes

 

[ajs]

@Sebastiii look for post above, on all old CPU MediaInfo crash, on new CPU work fine ...

 

[Sebastiii]

Ah yes
AVX is not compatible with my old CPU (first i7 i920) generation, it's like Tensor GPU compiled for AVX it crashes on old CPU.
So we can have a code to add on MP start to test current AVX MediaInfo (with a try/catch) and is it crash, use a SSE2 version, it's tricky but can work, or let using old version (SSE2) for old CPU and newer.

 

[catavolt]

or let using old version (SSE2) for old CPU and newer.

I prefer that solution - much safer for all users out there

 

[ajs]

So we can have a code to add on MP start to test current AVX MediaInfo (with a try/catch) and is it crash, use a SSE2 version, it's tricky but can work, or let using old version (SSE2) for old CPU and newer.

I'll check with @yartat, maybe he just replace the library in the package with the one that supports SSE2 or create a separate package, or another option. And then we will decide. While I think it is not worth doing anything on the side of the Media Portal.

 

[ajs]

Jira created - [MP1-5055] MediaInfo crash on old CPU - MediaPortal Jira

 

[ajs]

@yartat simply update MediaInfo library with SSE2 in nuget package

 

[ajs]

Branch created, build started, after build complete MP with new MediaInfo library here - AppVeyor
@TLD @Sebastiii @azzuro @catavolt Can you test?

 

[ajs]

Build complete ...