[TV] 4994: Automatically Change Channel on Program Reminder (2 Viewers)

[vapourEyes]

I'm gonna recheck the build of this DLL and resubmit a zip file.
It is odd that 'Yes' gets selected but the switch does not happen.

 

[404]

Yep really strange, I'm willing to stick with it until it's working though as it's a nice improvement and we haven't had many of those over the last few years due to the code freeze.

 

[404]

@vapourEyes how does the code determine which selection (yes/no) has been made?

 

[vapourEyes]

            tvNotifyDlg.SetDefaultToYes(true);
            tvNotifyDlg.DoModal(GUIWindowManager.ActiveWindow);

            if (tvNotifyDlg.IsConfirmed)
            {
              try
              {
                MediaPortal.Player.g_Player.Stop();
                if (c.IsTv)
                {
                  MediaPortal.GUI.Library.GUIWindowManager.ActivateWindow((int)MediaPortal.GUI.Library.GUIWindow.Window.WINDOW_TV);
                  TVHome.ViewChannelAndCheck(c);
                  if (TVHome.Card.IsTimeShifting && TVHome.Card.IdChannel == c.IdChannel)
                  {
                    g_Player.ShowFullScreenWindow();
                  }
                }
                else if (c.IsRadio)
                {
                  MediaPortal.GUI.Library.GUIWindowManager.ActivateWindow((int)MediaPortal.GUI.Library.GUIWindow.Window.WINDOW_RADIO);
                  Radio.CurrentChannel = c;
                  Radio.Play();
                }
              }
              catch (Exception e)
              {
                Log.Error("TVHome: TVNotification: Error on starting channel {0} after notification: {1} {2} {3}", notify.Channel.DisplayName, e.Message, e.Source, e.StackTrace);
              }
            }
            break;
          }

Setting default to true should satisfy if (tvNotifyDlg.IsConfirmed) and enable the change.

 

[404]

Can't see how there could be a problem, just tried 2 more reminders...same result, selecting 'OK' on the handset before the window closes changes the channel straight away.

 

[ajs]

Can't see how there could be a problem

The problem, if any, is in the tvNotifyDlg dialogue ...

 

[ajs]

tvNotifyDlg.SetDefaultToYes(true);
tvNotifyDlg.DoModal(GUIWindowManager.ActiveWindow);

Try add:

tvNotifyDlg.TimeOut = 5; // Seconds

 

[vapourEyes]

Above the snippet I shared is this though:

            tvNotifyDlg.SetImage(strLogo);
           tvNotifyDlg.TimeOut = _notifyTVTimeout;
            if (_playNotifyBeep)
            {
              MediaPortal.Util.Utils.PlaySound("notify.wav", false, true);
            }
            tvNotifyDlg.SetDefaultToYes(true);
            tvNotifyDlg.DoModal(GUIWindowManager.ActiveWindow);

            if (tvNotifyDlg.IsConfirmed)
            {
              try
              {
                MediaPortal.Player.g_Player.Stop();

                if (c.IsTv)
                {
                  MediaPortal.GUI.Library.GUIWindowManager.ActivateWindow((int)MediaPortal.GUI.Library.GUIWindow.Window.WINDOW_TV);
                  TVHome.ViewChannelAndCheck(c);
                  if (TVHome.Card.IsTimeShifting && TVHome.Card.IdChannel == c.IdChannel)
                  {
                    g_Player.ShowFullScreenWindow();
                  }
                }
                else if (c.IsRadio)
                {
                  MediaPortal.GUI.Library.GUIWindowManager.ActivateWindow((int)MediaPortal.GUI.Library.GUIWindow.Window.WINDOW_RADIO);
                  Radio.CurrentChannel = c;
                  Radio.Play();
                }
              }
              catch (Exception e)
              {
                Log.Error("TVHome: TVNotification: Error on starting channel {0} after notification: {1} {2} {3}", notify.Channel.DisplayName, e.Message, e.Source, e.StackTrace);
              }

Including the above 2 lines reveals that a timeout for the dialogue is set.
Should I still set the timeout to 5 ?

 

[ajs]

Should I still set the timeout to 5 ?

I think no... Should work MediaPortal/MediaPortal-1

 

[ajs]

_notifyTVTimeout

_notifyTVTimeout more than 0?