[Approved] Add VideoPlayer chapter and title support (1 Viewer)

Smeulf

Retired Team Member
  • Premium Supporter
  • October 27, 2010
    672
    454
    France
    France France
    Hello,

    As MKV supports chapters, and I suppose many video format in the future will, I implemented Chapter support into the VideoPlayer, based on Master branch.

    It gives us a basic MKV chapter support (chapters are named "Chapter 1", "Chapter 2"... atm, I plan to extend it with localized chapter names in the future).

    DVDPlayer, DBPlayer and LiveTvPlayer were reworked to match the new implementation.

    Please, feedback is welcome, specificly in LiveTVPlayer and DBPlayer (and also on MKV and DVD, but I already test those one).

    Cheers.

    Smeulf.
     

    Attachments

    Smeulf

    Retired Team Member
  • Premium Supporter
  • October 27, 2010
    672
    454
    France
    France France
    Added a second patch, because of an existing issue, causing problems for chapters and subtitles : Player UI contributor must must be initialized each time because of subtitles and chapters handling.

    If not initialized again, then subtitles and chapters are not handeled in the next video if "next button" is pressed while watching a playlist.

    [Edit]
    I think this patch can be better : The UIContributor should be initialized if Player ressource accessor or locator is not "no ressource", but I don't know how I should do that. Please Albert have a look :)
    [/Edit]
     

    Smeulf

    Retired Team Member
  • Premium Supporter
  • October 27, 2010
    672
    454
    France
    France France
    Two more patches today :

    Patch 3 : Retrive chapter name from IAMExtendSeecking

    Patch 4 : Enable MKV Editions support for the VideoPlayer (treated as Titles)

    Those 2 patches needs "Patch 1" to be applied correctly.
     

    Attachments

    morpheus_xx

    Lead Dev MP2
  • Team MediaPortal
  • March 24, 2007
    11,390
    6,966
    Germany Germany
    Country flag
    This looks good already, very good progress! I will create a new branch next week an collect patches there.

    Keep up the good work :)
     

    MJGraf

    Retired Team Member
  • Premium Supporter
  • January 13, 2006
    2,475
    1,385
    Country flag
    Hey Smeulf, looks like you're becoming a developer ;)
    Very nice job!
    Michael
     

    Smeulf

    Retired Team Member
  • Premium Supporter
  • October 27, 2010
    672
    454
    France
    France France
    Hey Smeulf, looks like you're becoming a developer ;)
    Very nice job!
    Michael
    Hehe, without Morpheus and Albert job, it would not have been possible. Basically I just moved some methods and copy parts of the code... I must admit I have no glory on it ;)

    Smeulf.
     

    Users Who Are Viewing This Thread (Users: 0, Guests: 1)

    Top Bottom