[Approved] ajp8164 patch rollup against 23209 (2 Viewers)

[ajp8164]

EDIT: I added the following two attachments and removed one attachment. Apply the fp1 (fixpack1) patch on top of the original (it's an incremental patch and only contains diffs for two source files). Simply replace the GUISpinButton implementation with the attached fp1 version.

Added attachments: GUISpinButton_fp1.cs, all_changes_patch_fp1.patch
Removed attachments: GUISpinButton.cs

Changes:

• Fixed a bug in the CheckButton that prevented correct detection of the control being selected (or not).
• Added SpinButton x,y "spin text" offset allowing for fine tuning the text position of the value of the control.
• Fixed bug in event handling of SpinButton.
• Fixed inadvertent changes in GUILabelControl that broke the TvPlugin.

-------

Mr Hipp (and all),

Attached is a roll up of all of my pending/incorporated patches since 23209 plus a few more as noted below. This patch can be applied against 23209 to get all of the changes in one shot

This roll up contains these pending/incorporated patches:

https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/guicheckbutton-implementation-68867/
https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/vertical-text-alignment-new-feature-68706/
https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/fadelabel-text-wrapping-button-control-fadelabel-new-features-67893/
https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/keeplook-new-gui-feature-68601/
https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/borders-your-images-buttons-new-feature-68447/
https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/fadelabel-text-clip-fix-68547/
https://forum.team-mediaportal.com/submit-patches-mediaportal-tv-server-etc-325/shadow-text-new-feature-67695/

This roll up also contains patches for the following items:

1. fade label button fix - fixes a problem with my patch incorrectly adding the wrap string when scrolling is not necessary.
2. label shadow fix - fixes a problem with detection of whether or not a shadow should be drawn (fix is more efficient than orig impl).
3. spin button control (new) - adds a new control similar to updownbutton but with different styling options and behavior (different enough that I really needed a new control). Will post complete description later - for now, have a look at the attached source code and the attached picture ;-)

Hope this helps in bringing all this work to the benefit of others. Thanks to all for your help!

-Andy

 

[CHli]

That's quite a reasonable amount of work ! Thank you !