ajp8164_stage Build Release Thread (5 Viewers)

[catavolt]

AW: ajp8164_stage Build Release Thread

On the first post of this thread...

 

[disaster123]

AW: ajp8164_stage Build Release Thread

oh OK but no sources available so he hasn't updated his branch already :-(

 

[catavolt]

AW: ajp8164_stage Build Release Thread

That´s unfortunately correct.

 

[joostzilla]

Re: AW: ajp8164_stage Build Release Thread

Andy, tried your 2010 build. Works straight away. Thanks.

 

[ajp8164]

Re: AW: ajp8164_stage Build Release Thread

oh OK but no sources available so he hasn't updated his branch already :-(

That´s unfortunately correct.

I am in the process of updating the branch now. Should be done soon. There were a lot of merges; someone has already updated the copyright notice!

 

[ajp8164]

Re: AW: ajp8164_stage Build Release Thread

Hi Andy, just tested your last release based on SVN 24657. Unfortunately the properties of "checkbutton" don´t work as expected. I used them e.g. for the skip step settings, they look great, BUT the values activated aren´t stored. Any ideas? And BIG for your efforts!

Hi catavolt -

It's ability to work is completely dependent on the implementation of the window that you are using. The GUICheckButton control relies on it's parent class (GUIControl) to hold the selection (true/false value); the GUIControl.Selected property. If the window implementation does not use this property to store the state then it will not be able to manage the value of the button from this control (we'd have to update the window implementation to look at Selected) and hence the value will not be used to persist to disk (MediaPortal.xml).

What window are you using? I'll have a look at the code.

Incidentally; my Focus skin relies on a "FocusPlugin" to do a lot of work. This plugin is essentially a reimplementation of several MP core windows including most all of the settings windows and weather. I may be able to look into avoiding having to do this but it was much easier for me to re implement the windows than to figure out how to sub-class or aggregate controls and preserve legacy behavior at the same time. The risk is in breaking every skin out there.

Followup note: with regard to its sibling control, GUISpinButton. You will not be able to use this control with existing winsows plugins. The plugin developer must change their code to use GUISpinButton. The button needs to be loaded with values and managed properly. It's not at all hard to do and I can post example code for anyone that is interested.

 

[ajp8164]

Re: AW: ajp8164_stage Build Release Thread

@ajp8164
is there any chance that you release a patch file so that everybody is able to patch his own build?

Not sure My changes have been integrating into MP since June/July and there have been many merges with other peoples changes since. If there is a way to diff my branch against the trunk I suppose a patch could be created. I don't know how to do that but am willing to give it a try if its possible.

 

[disaster123]

AW: ajp8164_stage Build Release Thread

mhm main question will there be any advantages for non skinning people like me?

 

[mironicus]

AW: ajp8164_stage Build Release Thread

I tried your build. Only one cosmetic thing I found - the single channel EPG view is little bit distorted.

 

[carreno]

Hi Andy, I have a little tested your build and why you have not included your skin "Focus" for test news improvement in the skin engine?

;-)