Apollo One (1 Viewer)

wizard123

Retired Team Member
  • Premium Supporter
  • January 24, 2012
    2,569
    2,680
    Home Country
    United Kingdom United Kingdom
    I may change the eye icons at some point they are just the ones from Athena for now but the location is still correct, the red tabs are definitely the way to go and i wouldn't worry about a legend because I'm planning on having a kind of tutorial overlay on first run when all is finished, we need to stick to the design to get the skin built and then minor things can be modified or themed after. Great work btw ;)
     

    ge2301

    Lead Design MP2
  • Team MediaPortal
  • January 11, 2014
    8,741
    3,501
    Stuttgart
    Home Country
    Germany Germany
    I may change the eye icons at some point they are just the ones from Athena for now but the location is still correct, the red tabs are definitely the way to go and i wouldn't worry about a legend because I'm planning on having a kind of tutorial overlay on first run when all is finished, we need to stick to the design to get the skin built and then minor things can be modified or themed after. Great work btw ;)

    Ok, will complete the changes until end of the week before leaving and upload to Github branch.

    I think there should be a setting menu for skins somewhere later. Same is also done for Kodi. In this settings everybody can configure the skin according to his/her understanding. This can be from color palette until icon style. Tastes are different and there will be never a skin that can satisfy everybody 100% :)
     

    morpheus_xx

    Retired Team Member
  • Team MediaPortal
  • March 24, 2007
    12,073
    7,459
    Home Country
    Germany Germany
    and upload to Github branch.
    Please check your mail account for a kind of activation request, in GitHub you are still listed as "pending".

    This can be from color palette until icon style. Tastes are different and there will be never a skin that can satisfy everybody 100%
    Not sure if we should create an editor. But doing a theme is fairly simple, then you can just override the colors and images you don't like.
     

    ge2301

    Lead Design MP2
  • Team MediaPortal
  • January 11, 2014
    8,741
    3,501
    Stuttgart
    Home Country
    Germany Germany
    Please check your mail account for a kind of activation request, in GitHub you are still listed as "pending".
    I found the mail and clicked on the verification link once again: "ge2301@xxxxxxx.com is already verified."
    There must be another problem. I can also login w/o problem.

    Not sure if we should create an editor. But doing a theme is fairly simple, then you can just override the colors and images you don't like.
    Thats also right, by themes most topics can be covered ...

    @morpheus_xx
    I realized, that the red bar for watched covers is also visible in the list view, because I added it to "GridViewMovieItemTemplate".
    Where can I place the code, that the list view is not affected? As far as I see the "ListViewMovieItemTemplate" is referring to "GridViewMovieItemTemplate"
    Code:
          <Control x:Name="ListViewCover" Grid.Row="0" Grid.Column="0" Grid.RowSpan="2" Margin="0,0,10,0"
                   Template="{ThemeResource GridViewMovieItemTemplate}" RenderTransformOrigin="0.5,0.5"
                   IsVisible="{Binding RelativeSource={RelativeSource Mode=FindAncestor,AncestorType={x:Type Button}},Path=HasFocus}">
     

    morpheus_xx

    Retired Team Member
  • Team MediaPortal
  • March 24, 2007
    12,073
    7,459
    Home Country
    Germany Germany
    because I added it to "GridViewMovieItemTemplate"
    This is right.

    Can you post the xaml of modification here?

    Where can I place the code, that the list view is not affected? As far as I see the "ListViewMovieItemTemplate" is referring to "GridViewMovieItemTemplate"
    Good question. The "<Control x:Name="ListViewCover"...>" is implemented as reference to the cover view, because I wanted to remove rendundancies in xaml code (you know: define once, use multiple times...)

    Now this is not the best for our different styles. We could "inline" the control into list view style, but this would bring back redundancies. Another option could be a "Setter" in a style which hides the red underlay when the control is used in list view. I have not tested this yet, so I first have to check the best way.
     

    ge2301

    Lead Design MP2
  • Team MediaPortal
  • January 11, 2014
    8,741
    3,501
    Stuttgart
    Home Country
    Germany Germany
    Can you post the xaml of modification here?
    Ok, I attached it.
    Edit: Also added the pics, that need to be extracted to images folder

    The previous problem came back. MP crashes, if I click on buttons. It happens only in Apollo skin.
    • I exchanged the modified xaml's to original ones --> still crashing
    • recompiling is only possible w/o eror, if I delete the complete build
    • Then it's working again, but once I copy back the modified xaml's --> crash
    • Restoring the original ones --> crash
    Last time I had this failure I wrote the same changes to a fresh xaml after compiling and it works.
    Curious, if you face problems with attached xaml.
     

    Attachments

    • MediaStyles_backup_14012015.7z
      6.9 KB
    • images.7z
      6.6 KB
    Last edited:

    morpheus_xx

    Retired Team Member
  • Team MediaPortal
  • March 24, 2007
    12,073
    7,459
    Home Country
    Germany Germany
    There is one invalid comment, I guess this is the reason:
    XML:
      < GE2301: Unwatched marker added by symbol -->
    (sorry, wrong... continue checking now)

    Can you attach the MediaItem_Unwatched.png?
     

    morpheus_xx

    Retired Team Member
  • Team MediaPortal
  • March 24, 2007
    12,073
    7,459
    Home Country
    Germany Germany
    Ah, now I think to know the cause:

    In project's build process the output files are copied to final folder (bin\MP2-Client...). This happens by the "build.targets" file, which describes what to copy where:
    <SkinFiles Include="$(ProjectDir)Skin\**\*.*" />
    --> this means all(!) files are copied to target, missing ones are not deleted in target folder. So if you have copies of mediaStyles.xaml with errors, the copy process copies them to target and the MP2 will try to load them.

    So generally: don't place any other files into Skin folder which you might not want to copy.

    To clean up a single plugin, you can delete only ApolloOne plugin and in VS right click project -> rebuild.
     

    morpheus_xx

    Retired Team Member
  • Team MediaPortal
  • March 24, 2007
    12,073
    7,459
    Home Country
    Germany Germany
    Can you post the xaml of modification here?
    Zitat von ge2301: ↑
    Where can I place the code, that the list view is not affected? As far as I see the "ListViewMovieItemTemplate" is referring to "GridViewMovieItemTemplate"
    Good question. The "<Control x:Name="ListViewCover"...>" is implemented as reference to the cover view, because I wanted to remove rendundancies in xaml code (you know: define once, use multiple times...)

    I would use this version:
    XML:
      <ControlTemplate x:Key="MovieCoverTemplate">
        <Grid>
          <Image Source="MediaItem_Shadow.png" Margin="-7,-4,-8,-6"/>
          <Image Width="{StaticResource MEDIA_POSTER_WIDTH}" Height="{StaticResource MEDIA_POSTER_HEIGHT}" Stretch="UniformToFill" FallbackSource="VideoLarge.png"
                 OpacityMask="{ThemeResource MediaItemsOpacityBrush}">
            <Image.Source>
              <fanart:FanArtImageSource fanart:FanArtMediaType="Movie" fanart:FanArtType="Poster" fanart:FanArtName="{Binding SimpleTitle}"
                  fanart:MaxWidth="{StaticResource FANART_POSTER_WIDTH}" fanart:MaxHeight="{StaticResource FANART_POSTER_HEIGHT}"/>
            </Image.Source>
          </Image>
        </Grid>
      </ControlTemplate>
     
      <ControlTemplate x:Key="GridViewMovieItemTemplate">
        <Grid>
          <Image Source="MediaItem_Unwatched.png" Margin="-7,-4,-8,-6">
            <Image.IsVisible>
              <Binding Path="PlayCount" Converter="{StaticResource ExpressionValueConverter}" ConverterParameter="{}{0} == 0"/>
            </Image.IsVisible>
          </Image>
          <Control Template="{ThemeResource MovieCoverTemplate}"/>
        </Grid>
      </ControlTemplate>
    --> Cover remains as own template (MovieCoverTemplate)
    --> GridViewMovieItemTemplate wraps around MovieCoverTemplate, places the unwatched png under it
    --> ListView style needs to rederence MovieCoverTemplate (instead of GridViewMovieItemTemplate)
     

    Users who are viewing this thread

    Top Bottom